-
-
Notifications
You must be signed in to change notification settings - Fork 709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor default views to use register_routes #870
Comments
This would be a lot easier if I had extracted out the hash logic to a plugin, see: |
There's a lot of complex logic in the That view subclasses |
The key to all of this may be the Lines 904 to 938 in 0991ea7
|
Since I could also rename it to just |
Maybe I could add a datasette/datasette/utils/asgi.py Lines 150 to 174 in a8bcafc
Or I could teach the |
I'm going to ditch that |
So now the problem is simpler: I need to get |
This code is interesting: Lines 948 to 955 in 3bc2461
I want to change the signature of that The problem is the scope modification: I have code that modifies the scope, but how should that impact a shared |
I'm going to create the single Lines 905 to 925 in 3bc2461
|
I've made enough progress on this to be able to solve the messages issue in #864. I may still complete this overall goal (registering internal views with |
It would be much cleaner if Datasette's default views were all registered using the new
register_routes()
plugin hook. Could dramatically reduce the code indatasette/app.py
.The text was updated successfully, but these errors were encountered: