Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datasette sdist is missing templates (hence broken when installing from Homebrew) #930

Closed
simonw opened this issue Aug 12, 2020 · 6 comments
Labels

Comments

@simonw
Copy link
Owner

simonw commented Aug 12, 2020

Pretty nasty bug this: I'm getting 500 errors for all pages that try to render a template after installing the newly released Datasette 0.47 - both from pip install and via Homebrew.

@simonw simonw added the bug label Aug 12, 2020
@simonw simonw changed the title Datasette 0.47 templates are broken Datasette 0.47 templates are broken when installing from Homebrew Aug 12, 2020
@simonw
Copy link
Owner Author

simonw commented Aug 12, 2020

Correction: pip installed Datasette works fine, it's just the Homebrew release that is broken.

@simonw
Copy link
Owner Author

simonw commented Aug 12, 2020

I checked and datasette publish deploys a 0.47 version that works fine too: https://datasette-0-47-j7hipcg4aq-uc.a.run.app/-/versions

@simonw simonw changed the title Datasette 0.47 templates are broken when installing from Homebrew Datasette sdist is missing templates (hence broken when installing from Homebrew) Aug 12, 2020
@simonw
Copy link
Owner Author

simonw commented Aug 12, 2020

The root cause appears to be that the templates/ are missing from the sdist .tar.gz: simonw/homebrew-datasette#6 (comment)

@simonw
Copy link
Owner Author

simonw commented Aug 12, 2020

OK, this has fixed it - I used sdist to create the .tar.gz and then pip installed it into a new environment, and everything worked just fine. Going to ship this as Datasette 0.47.1.

simonw added a commit that referenced this issue Aug 12, 2020
@simonw
Copy link
Owner Author

simonw commented Aug 12, 2020

Homebrew install is now fixed, using a temporary URL while waiting for Travis to ship the new release to PyPI: simonw/homebrew-datasette#6

@simonw
Copy link
Owner Author

simonw commented Aug 12, 2020

@simonw simonw closed this as completed Aug 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant