Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

register_output_renderer render function should be able to return a Response #953

Closed
simonw opened this issue Aug 28, 2020 · 1 comment
Closed

register_output_renderer render function should be able to return a Response #953

simonw opened this issue Aug 28, 2020 · 1 comment
Labels
enhancement plugins
Milestone
Datasette 0.49

Comments

@simonw
Copy link
Owner

simonw commented Aug 28, 2020

That plugin hook was designed before Datasette had a documented Response class. It should optionally be allowed to return a Response in addition to the current custom dictionary.
@simonw simonw closed this as completed in 799ecae Aug 28, 2020
@simonw
Copy link
Owner Author

simonw commented Aug 28, 2020

Documentation says that the old dictionary mechanism will be deprecated by 1.0:

datasette/docs/plugin_hooks.rst

Line 460 in 799ecae

It can also return a dictionary with the following keys. This format is **deprecated** as-of Datasette 0.49 and will be removed by Datasette 1.0.

@simonw simonw mentioned this issue Aug 28, 2020
Open
@simonw simonw added this to the Datasette 0.49 milestone Aug 28, 2020
@simonw simonw mentioned this issue Aug 28, 2020
Closed
simonw added a commit that referenced this issue Aug 28, 2020
@simonw
Release notes for 0.49a0
7178126 
Refs #953, #945
simonw added a commit that referenced this issue Sep 14, 2020
@simonw
Release 0.49
c024952 
Refs #880, #944, #945, #947, #948, #953, #958, #962, #963, #964, #965
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement plugins
Projects
None yet
Milestone
Datasette 0.49
Development

No branches or pull requests
1 participant
@simonw