Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Offer to format readonly SQL #602

Merged
merged 1 commit into from
Nov 4, 2019
Merged

Offer to format readonly SQL #602

merged 1 commit into from
Nov 4, 2019

Conversation

rixx
Copy link
Contributor

@rixx rixx commented Oct 20, 2019

Following discussion in #601, this PR adds a "Format SQL" button to
read-only SQL (if the SQL actually differs from the formatting result).

It also removes a console error on readonly SQL queries.

@rixx
Offer to format readonly SQL
266c3da 
Following discussion in simonw#601, this PR adds a "Format SQL" button to
read-only SQL (if the SQL actually differs from the formatting result).

It also removes a console error on readonly SQL queries.
@rixx rixx mentioned this pull request Oct 20, 2019
Merged
@simonw simonw merged commit ee33022 into simonw:master Nov 4, 2019
@simonw
Copy link
Owner

simonw commented Nov 4, 2019

Live demo can now be seen here: https://latest.datasette.io/fixtures/%F0%9D%90%9C%F0%9D%90%A2%F0%9D%90%AD%F0%9D%90%A2%F0%9D%90%9E%F0%9D%90%AC

@simonw
Copy link
Owner

simonw commented Nov 4, 2019

I wonder if the Format SQL button should disappear in the read-only case once it has been clicked? It won't do anything if it's clicked again and there's no textarea for the user to mess up the now-formatted SQL.

@rixx rixx deleted the format-readonly-sql branch November 4, 2019 07:29
@rixx
Copy link
Contributor Author

rixx commented Nov 4, 2019

Not sure – I'm always a bit weirded out when elements that I clicked disappear on me.

simonw pushed a commit that referenced this pull request Nov 11, 2019
@rixx @simonw
Offer to format readonly SQL (#602)
fa4d77b 
Following discussion in #601, this PR adds a "Format SQL" button to
read-only SQL (if the SQL actually differs from the formatting result).

It also removes a console error on readonly SQL queries.

Thanks, @rixx!
simonw pushed a commit that referenced this pull request Nov 15, 2019
@rixx @simonw
Offer to format readonly SQL (#602)
ff04c26 
Following discussion in #601, this PR adds a "Format SQL" button to
read-only SQL (if the SQL actually differs from the formatting result).

It also removes a console error on readonly SQL queries.

Thanks, @rixx!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rixx @simonw