Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datasette.render_template() method #664

Merged
merged 8 commits into from Feb 4, 2020
Merged

Datasette.render_template() method #664

merged 8 commits into from Feb 4, 2020

Conversation

@simonw
Copy link
Owner

simonw commented Feb 4, 2020

Refs #577

simonw added 3 commits Feb 4, 2020
@simonw

This comment has been minimized.

Copy link
Owner Author

simonw commented Feb 4, 2020

Needs documentation.

@simonw simonw changed the title Datasatte.render_template() method Datasette.render_template() method Feb 4, 2020
@simonw

This comment has been minimized.

Copy link
Owner Author

simonw commented Feb 4, 2020

More importantly, I need to prototype up a plugin that actually uses this method - probably datasette-upload-csvs - to make sure it serves its purpose.

@simonw

This comment has been minimized.

Copy link
Owner Author

simonw commented Feb 4, 2020

It doesn't make sense for extra body scripts to be available for all template renders (including from plugins) but extra CSS and JS to only be handled by the BaseView render method - especially since extra body scripts are likely to depend on extra JS files.

simonw added 3 commits Feb 4, 2020
@simonw

This comment has been minimized.

Copy link
Owner Author

simonw commented Feb 4, 2020

I'm going to ship this without documentation, get a couple of plugins out that use it and then add documentation once I'm confident it's right.

@simonw

This comment has been minimized.

Copy link
Owner Author

simonw commented Feb 4, 2020

See #576 for existing ticket covering Datasette class documentation.

@simonw simonw merged commit 70b915f into master Feb 4, 2020
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.