Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load only python files from plugins-dir. #890

merged 2 commits into from Jul 3, 2020


Copy link

@amjith amjith commented Jul 3, 2020

The current behavior for --plugins-dir is to load every file in that folder as a python module. This can result in errors if there are non-python files in the plugins dir (such as .mypy_cache).

This PR restricts the module loading to only python files.

Copy link

codecov bot commented Jul 3, 2020

Codecov Report

Merging #890 into master will decrease coverage by 0.01%.
The diff coverage is 80.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #890      +/-   ##
- Coverage   83.42%   83.40%   -0.02%     
  Files          27       27              
  Lines        3632     3634       +2     
+ Hits         3030     3031       +1     
- Misses        602      603       +1     
Impacted Files Coverage Δ
datasette/ 95.99% <80.00%> (-0.17%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57879dc...745af3b. Read the comment docs.

Copy link

simonw commented Jul 3, 2020

This is an excellent fix. Thanks!

Not sure why codecov is complaining. I'm going to merge it as-is.

@simonw simonw merged commit ea99a44 into simonw:master Jul 3, 2020
0 of 2 checks passed
simonw added a commit that referenced this pull request Aug 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants