Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump django from 2.2 to 2.2.1 #25

Merged
merged 1 commit into from May 27, 2019

Conversation

Projects
None yet
1 participant
@dependabot-preview
Copy link
Contributor

commented May 27, 2019

Bumps django from 2.2 to 2.2.1.

Commits
  • d5b0625 [2.2.x] Bumped version for 2.2.1 release.
  • 9d5ce09 [2.2.x] Updated man page for Django 2.2.
  • e7629ce [2.2.x] Added release date for 2.2.1.
  • 58391b4 [2.2.x] Fixed #30412 -- Fixed crash when adding check constraints with OR'ed ...
  • 54fcdf1 [2.2.x] Fixed #20629 -- Rephrased custom user models admonition.
  • f36239f [2.2.x] Fixed #30408 -- Fixed crash when adding check constraints with LIKE o...
  • d326c74 [2.2.x] Fixed #30323 -- Fixed detecting changes by autoreloader when using St...
  • 097457a [2.2.x] Refs #30323 -- Prevented crash of autoreloader when get_resolver().ur...
  • 4f8ebdd [2.2.x] Fixed #30351 -- Handled pre-existing permissions in proxy model permi...
  • e457631 [2.2.x] Fixed #30361 -- Increased the default timeout of watchman client to 5...
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Note: This repo was added to Dependabot recently, so you'll receive a maximum of 5 PRs for your first few update runs. Once an update run creates fewer than 5 PRs we'll remove that limit.

You can always request more updates by clicking Bump now in your Dependabot dashboard.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot ignore this [patch|minor|major] version will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Pull request limits (per update run and/or open at any time)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

Finally, you can contact us by mentioning @dependabot.


Dependabot has been acquired by GitHub  🎉

@dependabot-preview dependabot-preview bot force-pushed the dependabot/pip/django-2.2.1 branch 5 times, most recently from df9eab0 to 600f159 May 27, 2019

@simonw

This comment has been minimized.

Copy link
Owner

commented May 27, 2019

I happen to know this causes problems - when I tried to upgrade to 2.2.1 a while ago I got errors when I attempted to save updates to items using the Django admin.

This error here:

Environment:


Request Method: POST
Request URL: http://0.0.0.0:8033/admin/blog/blogmark/5869/change/

Django Version: 2.2.1
Python Version: 3.7.2
Installed Applications:
('django.contrib.admin',
 'django.contrib.auth',
 'django.contrib.contenttypes',
 'django.contrib.sessions',
 'django.contrib.messages',
 'django.contrib.staticfiles',
 'blog',
 'redirects',
 'feedstats',
 'debug_toolbar')
Installed Middleware:
('debug_toolbar.middleware.DebugToolbarMiddleware',
 'redirects.middleware.redirect_middleware',
 'django.middleware.security.SecurityMiddleware',
 'django.contrib.sessions.middleware.SessionMiddleware',
 'django.middleware.common.CommonMiddleware',
 'django.middleware.csrf.CsrfViewMiddleware',
 'django.contrib.auth.middleware.AuthenticationMiddleware',
 'django.contrib.messages.middleware.MessageMiddleware',
 'django.middleware.clickjacking.XFrameOptionsMiddleware')



Traceback:

File "/Users/simonw/.local/share/virtualenvs/simonwillisonblog-dAKOjw_Q/lib/python3.7/site-packages/django/core/handlers/exception.py" in inner
  34.             response = get_response(request)

File "/Users/simonw/.local/share/virtualenvs/simonwillisonblog-dAKOjw_Q/lib/python3.7/site-packages/django/core/handlers/base.py" in _get_response
  115.                 response = self.process_exception_by_middleware(e, request)

File "/Users/simonw/.local/share/virtualenvs/simonwillisonblog-dAKOjw_Q/lib/python3.7/site-packages/django/core/handlers/base.py" in _get_response
  113.                 response = wrapped_callback(request, *callback_args, **callback_kwargs)

File "/Users/simonw/.local/share/virtualenvs/simonwillisonblog-dAKOjw_Q/lib/python3.7/site-packages/django/contrib/admin/options.py" in wrapper
  606.                 return self.admin_site.admin_view(view)(*args, **kwargs)

File "/Users/simonw/.local/share/virtualenvs/simonwillisonblog-dAKOjw_Q/lib/python3.7/site-packages/django/utils/decorators.py" in _wrapped_view
  142.                     response = view_func(request, *args, **kwargs)

File "/Users/simonw/.local/share/virtualenvs/simonwillisonblog-dAKOjw_Q/lib/python3.7/site-packages/django/views/decorators/cache.py" in _wrapped_view_func
  44.         response = view_func(request, *args, **kwargs)

File "/Users/simonw/.local/share/virtualenvs/simonwillisonblog-dAKOjw_Q/lib/python3.7/site-packages/django/contrib/admin/sites.py" in inner
  223.             return view(request, *args, **kwargs)

File "/Users/simonw/.local/share/virtualenvs/simonwillisonblog-dAKOjw_Q/lib/python3.7/site-packages/django/contrib/admin/options.py" in change_view
  1637.         return self.changeform_view(request, object_id, form_url, extra_context)

File "/Users/simonw/.local/share/virtualenvs/simonwillisonblog-dAKOjw_Q/lib/python3.7/site-packages/django/utils/decorators.py" in _wrapper
  45.         return bound_method(*args, **kwargs)

File "/Users/simonw/.local/share/virtualenvs/simonwillisonblog-dAKOjw_Q/lib/python3.7/site-packages/django/utils/decorators.py" in _wrapped_view
  142.                     response = view_func(request, *args, **kwargs)

File "/Users/simonw/.local/share/virtualenvs/simonwillisonblog-dAKOjw_Q/lib/python3.7/site-packages/django/contrib/admin/options.py" in changeform_view
  1522.             return self._changeform_view(request, object_id, form_url, extra_context)

File "/Users/simonw/.local/share/virtualenvs/simonwillisonblog-dAKOjw_Q/lib/python3.7/site-packages/django/db/transaction.py" in __exit__
  284.                     connection.set_autocommit(True)

File "/Users/simonw/.local/share/virtualenvs/simonwillisonblog-dAKOjw_Q/lib/python3.7/site-packages/django/db/backends/base/base.py" in set_autocommit
  410.             self.run_and_clear_commit_hooks()

File "/Users/simonw/.local/share/virtualenvs/simonwillisonblog-dAKOjw_Q/lib/python3.7/site-packages/django/db/backends/base/base.py" in run_and_clear_commit_hooks
  636.             func()

File "/Users/simonw/Dropbox/Development/simonwillisonblog/blog/signals.py" in on_commit
  40.             search_document=reduce(operator.add, search_vectors)

File "/Users/simonw/.local/share/virtualenvs/simonwillisonblog-dAKOjw_Q/lib/python3.7/site-packages/django/db/models/query.py" in update
  737.         query.add_update_values(kwargs)

File "/Users/simonw/.local/share/virtualenvs/simonwillisonblog-dAKOjw_Q/lib/python3.7/site-packages/django/db/models/sql/subqueries.py" in add_update_values
  129.         return self.add_update_fields(values_seq)

File "/Users/simonw/.local/share/virtualenvs/simonwillisonblog-dAKOjw_Q/lib/python3.7/site-packages/django/db/models/sql/subqueries.py" in add_update_fields
  140.                 val = val.resolve_expression(self, allow_joins=False, for_save=True)

File "/Users/simonw/.local/share/virtualenvs/simonwillisonblog-dAKOjw_Q/lib/python3.7/site-packages/django/db/models/expressions.py" in resolve_expression
  446.         c.lhs = c.lhs.resolve_expression(query, allow_joins, reuse, summarize, for_save)

File "/Users/simonw/.local/share/virtualenvs/simonwillisonblog-dAKOjw_Q/lib/python3.7/site-packages/django/db/models/expressions.py" in resolve_expression
  446.         c.lhs = c.lhs.resolve_expression(query, allow_joins, reuse, summarize, for_save)

File "/Users/simonw/.local/share/virtualenvs/simonwillisonblog-dAKOjw_Q/lib/python3.7/site-packages/django/contrib/postgres/search.py" in resolve_expression
  69.             ) for expression in resolved.get_source_expressions()

File "/Users/simonw/.local/share/virtualenvs/simonwillisonblog-dAKOjw_Q/lib/python3.7/site-packages/django/contrib/postgres/search.py" in <listcomp>
  69.             ) for expression in resolved.get_source_expressions()

File "/Users/simonw/.local/share/virtualenvs/simonwillisonblog-dAKOjw_Q/lib/python3.7/site-packages/django/utils/functional.py" in __get__
  80.         res = instance.__dict__[self.name] = self.func(instance)

File "/Users/simonw/.local/share/virtualenvs/simonwillisonblog-dAKOjw_Q/lib/python3.7/site-packages/django/db/models/expressions.py" in output_field
  261.             raise FieldError('Cannot resolve expression type, unknown output_field')

Exception Type: FieldError at /admin/blog/blogmark/5869/change/
Exception Value: Cannot resolve expression type, unknown output_field

The cause appears to be this code:

def on_commit():
search_vectors = []
for weight, text in list(components.items()):
search_vectors.append(
SearchVector(Value(text), weight=weight)
)
instance.__class__.objects.filter(pk=pk).update(
search_document=reduce(operator.add, search_vectors)
)

I need to create a unit test that demonstrates this error, then I can fix it and merge this PR.

simonw added a commit that referenced this pull request May 27, 2019

@simonw

This comment has been minimized.

Copy link
Owner

commented May 27, 2019

@dependabot rebase

@dependabot-preview dependabot-preview bot force-pushed the dependabot/pip/django-2.2.1 branch from 600f159 to d1ee175 May 27, 2019

simonw added a commit that referenced this pull request May 27, 2019

@simonw

This comment has been minimized.

Copy link
Owner

commented May 27, 2019

@dependabot rebase

@simonw

This comment has been minimized.

Copy link
Owner

commented May 27, 2019

@dependabot badge me

@dependabot-preview

This comment has been minimized.

Copy link
Contributor Author

commented May 27, 2019

Dependabot Status

The markdown to add the above to your README is:

[![Dependabot Status](https://api.dependabot.com/badges/status?host=github&repo=simonw/simonwillisonblog)](https://dependabot.com)

@dependabot-preview dependabot-preview bot force-pushed the dependabot/pip/django-2.2.1 branch from d1ee175 to c8b8ab2 May 27, 2019

@simonw simonw merged commit 46a7982 into master May 27, 2019

1 check passed

ci/circleci: build Your tests passed on CircleCI!
Details

@dependabot-preview dependabot-preview bot deleted the dependabot/pip/django-2.2.1 branch May 27, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.