Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use python-dateutil package instead of dateutils #324

Merged
merged 1 commit into from Nov 14, 2021
Merged

Conversation

meatcar
Copy link
Contributor

@meatcar meatcar commented Sep 3, 2021

While working on updating sqlite-utils for NixOS/Nixpkgs, I came a cross the following:

In 5ec6686, a new dependency was added on dateutils (https://pypi.org/project/dateutils/).

I believe this is unintentional, and instead python-dateutil (https://pypi.org/project/python-dateutil/) was intended.

My reasoning is:

  • python-dateutil is imported here in recipes.py
  • The mypy type-python-dateutil dependency in setup.py
  • python-dateutil is a dependency of dateutils as seen in the output in docs/tutorial.ipynb

Seems like the trailing "s" seems to be the source of confusion 馃槄

I've swapped the dependencies out, hope this helps.

@simonw
Copy link
Owner

simonw commented Nov 14, 2021

Yes this was absolutely the intention! Thanks, I wonder how often I've made that mistake in other projects?

@simonw simonw merged commit bc4c42d into simonw:main Nov 14, 2021
simonw added a commit that referenced this pull request Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants