Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

search_sql add include_rank option #480

Merged
merged 5 commits into from
Aug 31, 2022
Merged

Conversation

chapmanjacobd
Copy link
Contributor

@chapmanjacobd chapmanjacobd commented Aug 30, 2022

I haven't tested this yet but wanted to get a heads-up whether this kind of change would be useful or if I should just duplicate the function and tweak it within my code


📚 Documentation preview 📚: https://sqlite-utils--480.org.readthedocs.build/en/480/

@simonw
Copy link
Owner

simonw commented Aug 30, 2022

Yeah this seems like a reasonable addition to me.

Needs a test, which can go next to this one:

def test_search_sql(kwargs, fts, expected):

@codecov
Copy link

codecov bot commented Aug 30, 2022

Codecov Report

Base: 96.47% // Head: 96.47% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (3dbfca6) compared to base (087753c).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #480   +/-   ##
=======================================
  Coverage   96.47%   96.47%           
=======================================
  Files           6        6           
  Lines        2640     2642    +2     
=======================================
+ Hits         2547     2549    +2     
  Misses         93       93           
Impacted Files Coverage Δ
sqlite_utils/db.py 97.32% <100.00%> (+<0.01%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@chapmanjacobd
Copy link
Contributor Author

Thanks for pointing me to the right place

@simonw
Copy link
Owner

simonw commented Aug 31, 2022

Tests look great, thank you!

@simonw simonw merged commit ecf1d40 into simonw:main Aug 31, 2022
@simonw simonw mentioned this pull request Oct 25, 2022
simonw added a commit that referenced this pull request Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants