Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Building produces unusable script #1

Closed
ahti opened this issue Feb 7, 2013 · 3 comments
Closed

Building produces unusable script #1

ahti opened this issue Feb 7, 2013 · 3 comments
Assignees

Comments

@ahti
Copy link

ahti commented Feb 7, 2013

When I build a file via build.py the output file is not usable:

  1. It has an empty line at the beginning, making the hashbang not recognized. This is easily fixed by hand, BUT:
  2. Running the fixed file results in the following:
> ./mergepbx 
Traceback (most recent call last):
  File "<stdin>", line 5, in <module>
ImportError: No module named mergepbx

The same problems apply to the prebuilt variant mentioned in the readme.

I'm running python 2.7.3 on OSX 10.8.

@ghost ghost assigned simonwagner Feb 7, 2013
@simonwagner
Copy link
Owner

Could you specify the options you used for build.py? I tested the script and it works for me.

The correct usage is
./build.py mergepbx MANIFEST

@ahti
Copy link
Author

ahti commented Feb 7, 2013

i used the exact same options.
i just submitted a pull request which fixes the issue for me (although i don't know why it fixes the "no module named mergepbx" issue)

@simonwagner
Copy link
Owner

Hm, I think removing the newline messed with the offsets in the zip file that is appended after the header. I will merge your pull request as soon as I am home, thank you.

simonwagner added a commit that referenced this issue Feb 7, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants