Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(#140) Added parameters to control /etc/security/faillock.conf #141

Merged
merged 10 commits into from
Jan 29, 2024

Conversation

michael-riddle
Copy link
Member

No description provided.

@michael-riddle michael-riddle marked this pull request as draft December 19, 2023 15:45
@michael-riddle michael-riddle marked this pull request as ready for review January 3, 2024 14:55
@michael-riddle michael-riddle changed the title Draft: (#140) Added parameters to control /etc/security/faillock.conf (#140) Added parameters to control /etc/security/faillock.conf Jan 3, 2024
@michael-riddle michael-riddle marked this pull request as draft January 3, 2024 15:12
@michael-riddle
Copy link
Member Author

@silug suggested an additional test to make sure the format of the in-line faillock params are working as expected.

He also suggested refactoring the OS version comparisons to be more hiera-driven. Will need to get some clarification on what he meant by this before attempting to refactor.

@michael-riddle michael-riddle marked this pull request as ready for review January 29, 2024 18:49
manifests/config.pp Outdated Show resolved Hide resolved
spec/classes/config_spec.rb Show resolved Hide resolved
@michael-riddle michael-riddle merged commit 1a420f3 into simp:master Jan 29, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants