Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement suggestions: SIMPEG\directives\directives.py #1036

Open
aluthfian opened this issue Aug 31, 2021 · 2 comments
Open

Enhancement suggestions: SIMPEG\directives\directives.py #1036

aluthfian opened this issue Aug 31, 2021 · 2 comments

Comments

@aluthfian
Copy link

aluthfian commented Aug 31, 2021

As I am yet to understand what "Pull Requests" are, I want to propose some minor enhancements over the directives.py file.

Class SaveOutputDictEveryIteration: save to a directory option. (line 1183)

if self.saveOnDisk:
            fname = "{:03d}-{:s}".format(self.opt.iter, self.fileName)
            np.savez(os.path.join(self.directory, fname), iterDict)

self.outDict[self.opt.iter] = iterDict

Some Typos in Line 931

self.header = " # beta phi_d phi_m phi_m_small phi_m_smooth_x phi_m_smooth_y phi_m_smooth_z phi\n"

Thanks all for the great work!

@RichardScottOZ
Copy link
Contributor

If you find the file on the repository and edit it - it will make a fork for you to work in and start guiding you through it, too.

@RichardScottOZ
Copy link
Contributor

Or, short version - make your own version - ask to have it merged into the main work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants