New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

start a 1.0 release #29

Merged
merged 1 commit into from Oct 4, 2018

Conversation

Projects
None yet
2 participants
@kiwiupover
Contributor

kiwiupover commented Oct 4, 2018

Looks like this addon is really stable and could be bumped to 1.0
What else needs to be done to move ember-cli-deploy-webhooks to 1.0?

This PR bumps the version to 1.0.0-beta.1
Can we cut a npm release for this.

Thanks for maintaining this project.

Cheers
Dave

@marcoow

This comment has been minimized.

Show comment
Hide comment
@marcoow

marcoow Oct 4, 2018

Member

I'm all 👍 for releasing 1.0. I do think we should address #27 before that though.

Member

marcoow commented Oct 4, 2018

I'm all 👍 for releasing 1.0. I do think we should address #27 before that though.

@kiwiupover

This comment has been minimized.

Show comment
Hide comment
@kiwiupover

kiwiupover Oct 4, 2018

Contributor

#28 addressed #27 and #22

So both #27 and @22 can be closed.

I can change this PR to be the 1.0.0 if you would like.

Cheers

Contributor

kiwiupover commented Oct 4, 2018

#28 addressed #27 and #22

So both #27 and @22 can be closed.

I can change this PR to be the 1.0.0 if you would like.

Cheers

@marcoow

This comment has been minimized.

Show comment
Hide comment
@marcoow

marcoow Oct 4, 2018

Member

Ah perfect, I'm closing those then. Let's release 1.0.0-beta.1 for now and then update to 1.0.0 if no flood of issues comes in over the next few weeks or so.

Member

marcoow commented Oct 4, 2018

Ah perfect, I'm closing those then. Let's release 1.0.0-beta.1 for now and then update to 1.0.0 if no flood of issues comes in over the next few weeks or so.

@kiwiupover

This comment has been minimized.

Show comment
Hide comment
@kiwiupover

kiwiupover Oct 4, 2018

Contributor
Contributor

kiwiupover commented Oct 4, 2018

@marcoow

marcoow approved these changes Oct 4, 2018

@marcoow marcoow merged commit 8d47d64 into simplabs:master Oct 4, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@kiwiupover

This comment has been minimized.

Show comment
Hide comment
@kiwiupover

kiwiupover Oct 4, 2018

Contributor

@marcoow what is the best way to push this to NPM?
If can do that if you want I'm kiwiupover on npmjs.org

https://www.npmjs.com/~kiwiupover

Cheers
Dave

Contributor

kiwiupover commented Oct 4, 2018

@marcoow what is the best way to push this to NPM?
If can do that if you want I'm kiwiupover on npmjs.org

https://www.npmjs.com/~kiwiupover

Cheers
Dave

@kiwiupover kiwiupover deleted the kiwiupover:bump-version branch Oct 4, 2018

@marcoow

This comment has been minimized.

Show comment
Hide comment
@marcoow

marcoow Oct 5, 2018

Member

I pushed already; though we should have this running as part of the Travis build for master ideally… /cc @Turbo87

Member

marcoow commented Oct 5, 2018

I pushed already; though we should have this running as part of the Travis build for master ideally… /cc @Turbo87

@kiwiupover

This comment has been minimized.

Show comment
Hide comment
@kiwiupover

kiwiupover Oct 5, 2018

Contributor

@marcoow Thanks for pushing the beta to npm!
😃

Contributor

kiwiupover commented Oct 5, 2018

@marcoow Thanks for pushing the beta to npm!
😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment