Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update /guides/auth-torii-with-github.md #2208

Merged
merged 3 commits into from Jun 3, 2020
Merged

Update /guides/auth-torii-with-github.md #2208

merged 3 commits into from Jun 3, 2020

Conversation

sutharmonil
Copy link
Contributor

Includes minor corrections for closing bracket mismatch and preferred ember style of using fetch. Also, means no dependency on ember-ajax for this particular section atleast.

Includes minor corrections for closing bracket mismatch and preferred ember style of using fetch. Also, means no dependency on ember-ajax for this particular section atleast.
Copy link
Member

@marcoow marcoow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This looks good to me in general, I just have one question…

guides/auth-torii-with-github.md Outdated Show resolved Hide resolved
guides/auth-torii-with-github.md Outdated Show resolved Hide resolved
sutharmonil and others added 2 commits June 2, 2020 23:35
Removed redundant comment.

Co-authored-by: Marco Otte-Witte <marco.otte-witte@simplabs.com>
@marcoow marcoow merged commit b179acc into mainmatter:master Jun 3, 2020
@sutharmonil sutharmonil deleted the patch-1 branch June 3, 2020 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants