Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Ember Simple Auth an Ember CLI addon only (ESA 1.0) #522

Closed
wants to merge 102 commits into
base: master
from

Conversation

Projects
None yet
@marcoow
Copy link
Member

marcoow commented May 8, 2015

see #519

This will be the 1.0 release of Ember Simple Auth, turning the library into a first class Ember CLI addon and removing the bower and globals distributions. The 1.0 version will of course also support Ember 2.0.

  • turn the session into a service (actually there's a service now that wraps the session which itself isn't directly exposed anymore)
  • split the initialization code into initializers and instance initializers
  • make sure the documentation is correctly generated and convert all examples and references to Ember CLI/ES6 modules syntax
  • move the setup of $.ajaxPrefilter into a dedicated initializer that can optionally be loaded (there should probably also be an initializer that e.g. sets up authorization on the Ember Data adapter instead). The current method of automatically loading it should be extracted into an addon so it's easy to upgrade projects in a non-breaking way.
  • fix tests (currently fail in beta and canary because of emberjs/ember-mocha#48)

- [ ] rename Authenticator.restore to Authenticator.validate (don't think this is actually a good idea)

marcoow added some commits Jun 4, 2015

@adriaanvanrossum

This comment has been minimized.

Copy link

adriaanvanrossum commented Jul 28, 2015

What is the estimated time for this? Or is there another way to use this library with the newest ember version?

@marcoow

This comment has been minimized.

Copy link
Member Author

marcoow commented Jul 28, 2015

first beta will be released next week latest

@fotinakis

This comment has been minimized.

Copy link

fotinakis commented Jul 29, 2015

Excited to see that this is in progress, just upgraded to Ember 1.13.1 and this is the last remaining piece for me to finish. Let me know if I can help beta test.

@justinph

This comment has been minimized.

Copy link

justinph commented Jul 30, 2015

I'm looking forward to this as well. Will be happy to help beta test when available. Thanks for the hard work on it, @marcoow.

@marcoow marcoow closed this Aug 5, 2015

@marcoow marcoow deleted the ember-cli-addon branch Aug 5, 2015

@marcoow marcoow restored the ember-cli-addon branch Aug 5, 2015

@marcoow marcoow deleted the ember-cli-addon branch Aug 5, 2015

@marcoow marcoow referenced this pull request Aug 5, 2015

Merged

ESA 1.0 #602

13 of 13 tasks complete
@marcoow

This comment has been minimized.

Copy link
Member Author

marcoow commented Aug 5, 2015

see follow-up pull request #602

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.