Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add language direction #568

Merged
merged 3 commits into from Sep 14, 2018
Merged

Add language direction #568

merged 3 commits into from Sep 14, 2018

Conversation

@hishamco
Copy link
Member

@hishamco hishamco commented Sep 13, 2018

Address issue #557

@thiennn
Copy link
Contributor

@thiennn thiennn commented Sep 14, 2018

Nice! but can we have a tag helper or some thing similar to minimize the number line of code need to add to the _Layout, as we might have many _Layout for many themes

@hishamco
Copy link
Member Author

@hishamco hishamco commented Sep 14, 2018

Perhaps using TagHelperComponent is the suitable in this case, I will have a try if I can inject the language direction in the html tag in all the layouts

@hishamco
Copy link
Member Author

@hishamco hishamco commented Sep 14, 2018

Now it's totally clean, hope you like it 😄

@thiennn thiennn merged commit f9a5571 into simplcommerce:master Sep 14, 2018
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@hishamco hishamco deleted the hishamco:localization branch Sep 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.