New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remember users ordering preference #1053

Merged
merged 5 commits into from Nov 5, 2018

Conversation

3 participants
@ericcornelissen
Copy link
Contributor

ericcornelissen commented Nov 4, 2018

Issue: closes #999

Description

When this PR is merged the website will remember what sorting order the user last selected (either "by color" or "alphabetically"). It does this through the localStorage API. Even though it is widely supported I added if-statements checking if it is available before using it.

Misc: I also renamed the concept of "sorting" to "ordering" in the script, seems clearer to me 馃槂

@birjolaxew

This comment has been minimized.

Copy link
Member

birjolaxew commented Nov 5, 2018

馃憤 Looks good! Thanks for implementing this

@birjolaxew birjolaxew merged commit 92613a1 into simple-icons:develop Nov 5, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ericcornelissen ericcornelissen deleted the ericcornelissen:website/sort-preferences branch Nov 5, 2018

@birjolaxew birjolaxew referenced this pull request Nov 5, 2018

Merged

Publish Eventbrite #1057

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment