Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove aria-labelledby and ids from SVGs #1062

Merged

Conversation

@ericcornelissen
Copy link
Member

@ericcornelissen ericcornelissen commented Nov 6, 2018

Issue: #991

Description

This Pull Request removes the aria-labelledby attribute from all SVGs and the id attribute from all SVG <title>s. I updated the SVGLint configuration and documentation (i.e. README.md and CONTRIBUTING.md) accordingly.

As mentioned in the issue I tested this on Windows 10 using: Windows 10 build in Narrator, NVAccess, ChromeVox. Additionally we might want to test on MacOS, smartphone OSes and Linux (e.g. Ubuntu)(?).

Another thing we may consider doing is informing (existing) contributors about this change, as they will probably still include the two attributes when they submit a new icon 馃

@ericcornelissen ericcornelissen force-pushed the ericcornelissen:a11y/remove-aria-labelledby branch from c38a919 to dc3f9f1 Nov 6, 2018
@birjolaxew birjolaxew merged commit 4b88222 into simple-icons:develop Nov 6, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@birjolaxew
Copy link
Contributor

@birjolaxew birjolaxew commented Nov 6, 2018

馃憤 Great! Thanks for putting in the work to test and update this!

As for current contributors, I'm fine with informing them if they submit a PR with the old format - the build step should fail in those cases regardless.

@ericcornelissen
Copy link
Member Author

@ericcornelissen ericcornelissen commented Nov 6, 2018

As for current contributors, I'm fine with informing them if they submit a PR with the old format - the build step should fail in those cases regardless.

I agree. Just figured a heads-up in the template might be an idea. I also don't think adding temporary messages to the template is a particularly good idea.

@ericcornelissen ericcornelissen deleted the ericcornelissen:a11y/remove-aria-labelledby branch Nov 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants