Remove aria-labelledby and ids from SVGs #1062
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #991
Description
This Pull Request removes the
aria-labelledby
attribute from all SVGs and theid
attribute from all SVG<title>
s. I updated the SVGLint configuration and documentation (i.e. README.md and CONTRIBUTING.md) accordingly.As mentioned in the issue I tested this on Windows 10 using: Windows 10 build in Narrator, NVAccess, ChromeVox. Additionally we might want to test on MacOS, smartphone OSes and Linux (e.g. Ubuntu)(?).
Another thing we may consider doing is informing (existing) contributors about this change, as they will probably still include the two attributes when they submit a new icon 馃