Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Remove aria-labelledby and ids from SVGs #1062
This Pull Request removes the
As mentioned in the issue I tested this on Windows 10 using: Windows 10 build in Narrator, NVAccess, ChromeVox. Additionally we might want to test on MacOS, smartphone OSes and Linux (e.g. Ubuntu)(?).
Another thing we may consider doing is informing (existing) contributors about this change, as they will probably still include the two attributes when they submit a new icon
Nov 6, 2018
I agree. Just figured a heads-up in the template might be an idea. I also don't think adding temporary messages to the template is a particularly good idea.