Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add building instructions to CONTRIBUTING.md #490

Merged
merged 2 commits into from Aug 19, 2017
Merged

Add building instructions to CONTRIBUTING.md #490

merged 2 commits into from Aug 19, 2017

Conversation

@ericcornelissen
Copy link
Member

@ericcornelissen ericcornelissen commented Aug 17, 2017

Added instructions to CONTRIBUTING.md on how to build and run the site locally. As someone who has virtually no experience with Jekyll, I just wrote down what I did to get it working 馃槄 If there is something wrong with it, or something that could be made simpler, please feel free to suggest any changes!

@birjolaxew
Copy link
Contributor

@birjolaxew birjolaxew commented Aug 17, 2017

Thanks! I've been thinking of writing this, but it must've slipped my mind ^^

Are you sure you cannot simply jekyll serve, without step 1-3? IIRC, bundle exec jekyll serve fails, but jekyll by itself works fine.

@ericcornelissen
Copy link
Member Author

@ericcornelissen ericcornelissen commented Aug 17, 2017

@birjolaxew you're absolutely right that jekyll serve is all you really need 馃憤 That way Jekyll also doesn't generate a ton of files that are not ignored by git 馃槄

@birjolaxew birjolaxew requested review from benjaminwil and removed request for benjaminwil Aug 17, 2017
@birjolaxew
Copy link
Contributor

@birjolaxew birjolaxew commented Aug 17, 2017

馃憤 Going to leave this open until tomorrow to allow time for comments.

@benjaminwil
Copy link
Contributor

@benjaminwil benjaminwil commented Aug 18, 2017

馃憣

@birjolaxew birjolaxew merged commit 4899b66 into simple-icons:develop Aug 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants