New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update existing icons to adhere to the rules in the CONTRIBUTING.md #500

Merged
merged 3 commits into from Sep 3, 2017

Conversation

3 participants
@ericcornelissen
Copy link
Contributor

ericcornelissen commented Sep 3, 2017

Updated nearly* all of the existing icons to have to following:

  • Use aria-labelledby="title" and have <title>[NAME] icon</title>
  • Use role="img"
  • Use a viewBox of 24 by 24
  • Don't use fill-rule, clip-rule, stroke-linejoin and stroke-miterlimit

Besides that, also updated the index of some icons in the _data/simple-icons.json to follow the alphabetical ordering.

Note that not all icons are updated in this PR, it is possible to merge the PR as is but we should not forget to update the other icons (listed below) in the future!


*: Some icons have not yet been updated due to their dependency on either fill-rule, clip-rule, stroke-linejoin or stroke-miterlimit:

  • ACM
  • American Express
  • Automatic
  • Basecamp
  • Dailymotion
  • Ello
  • Empire Kred
  • Gauges
  • Geeklist
  • Google Hangouts
  • IMDb
  • InVision
  • Klout
  • MailChimp
  • Node.js
  • Odnoklassniki
  • Player.me
  • ProtonMail
  • Runkeeper
  • Simple Icons
  • Slides
  • Speaker Deck
  • Spotlight
  • StyleShare
  • Subversion
  • Toggl
  • Travis CI
  • Trello
  • Vue.js
  • Wix
  • Youtube
@birjolaxew

This comment has been minimized.

Copy link
Member

birjolaxew commented Sep 3, 2017

Massive props for all this work! Really very much appreciated.

I see a few icons have had their centering updated. Some for the better (👍), some are now slightly offset (e.g. AirBnB & CircleCI) - I think we'll handle that once we implement the linter at some point in the future :)

Really great work! Could you open an issue with the icons that need updating so we don't forget them?

@birjolaxew birjolaxew merged commit 41b5ffa into simple-icons:develop Sep 3, 2017

@ericcornelissen

This comment has been minimized.

Copy link
Contributor Author

ericcornelissen commented Sep 4, 2017

I manually centered them while resizing, I must have screwed up a few of them 😅

I did create an issue for the remaining icons 🙂

@ericcornelissen ericcornelissen deleted the ericcornelissen:update-icons branch Sep 4, 2017

@hokx

This comment has been minimized.

Copy link

hokx commented on _data/simple-icons.json in bc9f1c0 Jul 29, 2018

Greyed out

This comment has been minimized.

Copy link
Contributor Author

ericcornelissen replied Aug 1, 2018

No sure what you mean @hokx? Do you mean to say that Code School no longer exists as it was acquired by Pluralsight? I addressed that in #912

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment