Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Jeep #5011

Merged
merged 2 commits into from Feb 26, 2021
Merged

Updated Jeep #5011

merged 2 commits into from Feb 26, 2021

Conversation

adamrusted
Copy link
Member

@adamrusted adamrusted commented Feb 13, 2021

jeep

Issue: Contributes to #4578
Alexa rank: 9,857

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

Updated source to FCACI now it's been updated with Stellantis branding.
Used SVG embedded in pg11 of the PDF, ® icon seems to be pretty clear on that one.

Given Jeep use the ® symbol EVERYWHERE, I figured we should probably look to include it ourselves. Happy to maintain existing icon and just update source if others prefer that.

jeep

@github-actions github-actions bot added the update icon/data Issues or pull requests regarding icons that are outdated, this can be the SVG or color or both label Feb 13, 2021
@adamrusted adamrusted mentioned this pull request Feb 13, 2021
14 tasks
@PeterShaggyNoble
Copy link
Member

With regard to the "®", you are, unfortunately, right about its inclusion; I'd missed the following paragraph on page 3 of this PDF when I originally added it:

The Jeep brand mark consists of the Jeep logotype and the registration mark ® as one unit. The ® is an integral part of the Jeep brand mark design and may not be altered or deleted. The trademark registration symbol must appear with the Jeep brand mark in every application.

Looks like there are a few excess points that can be cleaned up here:

  • Bottom of the inner curve of the "J"
  • Top left of the "J"
  • Top of the 2 "e"s
  • In the "®"

And, as a follow-up to that last one, I wonder if we shouldn't create and supply our own versions of "®" & "™" for contributors to use in their SVGs as it's surprising the number of source files we come across where they are riddled with imperfections and/or excess points?

@adamrusted
Copy link
Member Author

Looks like there are a few excess points that can be cleaned up here:

Will pick this up tomorrow - I bashed these out pretty quickly yesterday - so figured there'd be a fair bit to tidy up.

I wonder if we shouldn't create and supply our own versions of "®" & "™" for contributors to use

I would've imagined there are default versions provided by the relevant trademark authorities, though of course there's likely to be optimizations we can make on our end. May be worth finding the 'best one' from our existing icons, and look at applying them across the board?

@adamrusted
Copy link
Member Author

@PeterShaggyNoble give that one a go - rebuilt from FCACI using a decent SVG found in the PDF.

@fbernhart
Copy link
Contributor

LGTM 👍🏼 Let me merge it.

@fbernhart fbernhart merged commit 2a9314b into simple-icons:develop Feb 26, 2021
ericcornelissen added a commit that referenced this pull request Feb 28, 2021
# New Icons

- AirAsia (#4892)
- AMP (#4962)
- Amul (#4955)
- Apostrophe (#4977)
- Apple Arcade (#4944)
- AssemblyScript (#4997)
- AutoHotkey (#4911)
- Baremetrics (#5118)
- Bitwig (#4958)
- CBS (#5122)
- Etihad Airways (#4957)
- Grammarly (#5045)
- KakaoTalk (#5016)
- Kasa Smart (#5114)
- KnowledgeBase (#4922)
- Max (#4981)
- MyAnimeList (#4718)
- Namebase (#5074)
- Nano (#5063)
- Nx (#4860)
- PlayCanvas (#5103)
- Plotly (#5111)
- Ram (#5014)
- reveal.js (#5127)
- Rezgo (#5100)
- S7 Airlines (#4888)
- Supabase (#4858)
- SurveyMonkey (#4790)
- SUSE (#4905)
- Swiggy (#4875)
- ts-node (#5105)
- Vaadin (#5007)

# Updated Icons

- Chrysler (#4991)
- Fiat (#5008)
- Jeep (#5011)
- Peugeot (#5119)
- Vauxhall (#5015)
@adamrusted adamrusted deleted the Update/Jeep branch March 5, 2021 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
update icon/data Issues or pull requests regarding icons that are outdated, this can be the SVG or color or both
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants