Add Json validator #527
Merged
Add Json validator #527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
馃憤 Thanks for implementing the linting! I've had this planned for a bit, but it's great that someone else got it done before me :) Really appreciated! On a related note, svglint is being worked on - at this point, the only things missing is implementing the rules (and fix any problems/redesigns that arise from that) |
|
Great @birjolaxew 馃憤 Btw, do you want me to write up an issue for the JSON schemas, or are you not interested in using that? |
|
That would be neat @ericcornelissen! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In response to #521, I added a JSON validator to validate the validity of
_data/simple-icons.jsonthat could/should be used with Continuous Integration (currently configured for Travis CI, but we could change to e.g. CircleCI or AppVeyor). You can see it effectshere orin the screenshot below (I intentionally made a commit with an incorrect .json file)I used jsonlint for this, which I added as a
devDependencyto the project inpackage.json. To make it easier to use I also added a npm script called jsonlint which automatically lints_data/simple-icons.json(without this script the command would have to look something likenode_modules/.bin/jsonlint _data/simple-icons.json -qin case jsonlint is not available globally).In the future we could even make use of JSON Schemes (which jsonlint supports 馃憤) to enforce e.g. certain data types on certain fields. You can find out more here and here.