Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fuzzy search #659

Merged
merged 1 commit into from Nov 1, 2017
Merged

Conversation

@ericcornelissen
Copy link
Member

@ericcornelissen ericcornelissen commented Nov 1, 2017

Updated the search method from a simple partially-equals method to a fuzzy search (also Approximate string matching) implementation.

Pro: this method is more forgiving, allowing users to make typos.
Con: search is more expensive in terms of CPU.

Let me know what you think and definitely try it out if you're unfamiliar with fuzzy search!


My implementation is based on this implementation: https://github.com/wouter2203/fuzzy-search

Updated the search method from a simple partially-equals method to a
fuzzy search (also Approximate string matching) implementation.

My implementation is based on an implementation by @ wouter2203:
https://github.com/wouter2203/fuzzy-search
@birjolaxew birjolaxew merged commit 04d9c94 into simple-icons:develop Nov 1, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@birjolaxew
Copy link
Contributor

@birjolaxew birjolaxew commented Nov 1, 2017

👍 Optimally we'd want a fuzzy algorithm that also handles substitution and deletion, but I see no need to force that onto this PR. Great idea and good work!

@ericcornelissen ericcornelissen deleted the ericcornelissen:fuzzy-search branch Nov 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants