Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WordPress plugin to README.md #796

Merged
merged 2 commits into from
Mar 21, 2018
Merged

Add WordPress plugin to README.md #796

merged 2 commits into from
Mar 21, 2018

Conversation

ericcornelissen
Copy link
Contributor

Closes #715

@birjj
Copy link
Contributor

birjj commented Mar 21, 2018

I think I would prefer to have a separate section for third party extensions. That way we separate officially supported (Node, CDN and file) usage from those that we have no control over. Something along the lines of

...

Node usage

The icons are also available through our npm package. To install, simply run:

$ npm install simple-icons

The API can then be used as follows:

...

Third party extensions

WordPress

Icons are also available through a simple WordPress plugin created by @tjtaylo - it can be found here.

We should also have a look at #478 (possibly pointing out #388), and possibly #454 and #443, while we're at it.

@ericcornelissen
Copy link
Contributor Author

I added the "Third party extensions" suggestion. However I'm hesitant to add the projects you pointed out because in my opinion they're a bit different from this WordPress plugin, except maybe for #478.

#454 seems more like a project using SimpleIcons, and #443 seems more like a fun side project rather then something people would use often (as the npm page also suggests)

@birjj
Copy link
Contributor

birjj commented Mar 21, 2018

👍 I agree with that assessment. I've also discovered that #478 doesn't automatically pull the newest release from here, and the last update was 9 months ago - so it can be considered abandoned.

I think that this is fine for now. Nice work @ericcornelissen!

@birjj birjj merged commit 821866c into simple-icons:develop Mar 21, 2018
@ericcornelissen ericcornelissen deleted the document-wordpress branch March 21, 2018 22:41
@ericcornelissen ericcornelissen added the docs Issues for improving or updating package documentation label Jul 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Issues for improving or updating package documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

I made a Simple Icons WordPress plugin
2 participants