Update the travis build to work in stages #948
Conversation
ericcornelissen
changed the title
There was a problem hiding this comment.
Great idea!
Note that when it comes to building and deploying in two separate stages, storage isn't shared amongst stages - this means that although we can (and should) use a single stage for testing that the build works, we will also have to run the build in the deploy stage.
[Edit] Whoops, didn't submit the inline comment. Guess it'll have to be here instead.
Minor thing, but could we add a conditional branch = master to the deploy stage, so that PRs targetting develop don't run an empty stage?
So PRs targetting develop don't run an empty stage. Related Travis Documentation: https://docs.travis-ci.com/user/conditional-builds-stages-jobs/
Good idea, I added the conditional and it seems to work. I left the conditional in the |
|
馃憤 Nice work on this! |
|
I'm happy to report that the deployment still works, see this Travis build 馃帀 |
davidklebanoff
added
the
meta
Improve the CI (test, build, and deploy) process by using build stages rather than a (somewhat hard to understand and arbitrary) build matrix. For now it just improves the readability of the
.travis.ymlfile and the understandability of the build status page.For clarity, I added two commits showing the build report when something goes wrong. The first is when the website cannot be build, and the second is when there is a linting error. As seen in the images below:
To summarize, Travis will now first lint & build the website (in parallel), and only if both succeed will it try to deploy. That only happens if the commit is on
master. So it is ignored most of the time, as seen here.In the future, with #898 in mind, this would make it easier to build to website in one step, and have it be deployed in another one (if that is even needed 馃), Possibly we could even load external files (e.g. simple-icons-pdf), and include them in the website. Also, extra test steps (such as described in #905) are now easier to add.