New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test the NPM package #972

Merged
merged 2 commits into from Sep 9, 2018

Conversation

2 participants
@ericcornelissen
Copy link
Contributor

ericcornelissen commented Sep 8, 2018

As per #905, this PR implements a (albeit simple) test suite for the generated NPM package using the testing framework Jest. Also adds a new Travis CI job that automatically executes the tests for us.

ericcornelissen added some commits Sep 8, 2018

Implement basic test for the NPM package
Just an initial test suite that checks if all promised imports actually 
exist. The testing framework Jest was chosen because of it ease of setup 
and use.

@ericcornelissen ericcornelissen added the meta label Sep 9, 2018

@birjolaxew

This comment has been minimized.

Copy link
Member

birjolaxew commented Sep 9, 2018

👍 Very nice! Thanks for taking care of this.

@birjolaxew birjolaxew merged commit e648507 into simple-icons:develop Sep 9, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ericcornelissen ericcornelissen deleted the ericcornelissen:test/npm-package branch Sep 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment