Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test the NPM package #972

Merged
merged 2 commits into from Sep 9, 2018
Merged

Test the NPM package #972

merged 2 commits into from Sep 9, 2018

Conversation

ericcornelissen
Copy link
Contributor

As per #905, this PR implements a (albeit simple) test suite for the generated NPM package using the testing framework Jest. Also adds a new Travis CI job that automatically executes the tests for us.

Just an initial test suite that checks if all promised imports actually 
exist. The testing framework Jest was chosen because of it ease of setup 
and use.
@ericcornelissen ericcornelissen added the meta Issues or pull requests regarding the project or repository itself label Sep 9, 2018
@birjj
Copy link
Contributor

birjj commented Sep 9, 2018

👍 Very nice! Thanks for taking care of this.

@birjj birjj merged commit e648507 into simple-icons:develop Sep 9, 2018
@ericcornelissen ericcornelissen deleted the test/npm-package branch September 9, 2018 20:24
@ericcornelissen ericcornelissen added the package Pull requests or issues that affect the NPM package label Jul 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta Issues or pull requests regarding the project or repository itself package Pull requests or issues that affect the NPM package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants