New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add `Icon` prop to component #1

Closed
wants to merge 1 commit into
base: master
from

Conversation

2 participants
@EyMaddis
Copy link
Collaborator

EyMaddis commented Jan 11, 2019

  • Adding the possibility of the user passing a custom Icon prop to be
    rendered instead of the default one
  • Added README.md instructions
  • Add tests for the new behaviour
  • Change testID keys to not mindd about platforms anymore
  • Refactored renderAndroid because of Cognitive Complexity issue on
    code climate
Add `Icon` prop to component
- Adding the possibility of the user passing a custom `Icon` prop to be
rendered instead of the default one
- Added README.md instructions
- Add tests for the new behaviour
- Change testID keys to not mindd about platforms anymore
- Refactored renderAndroid because of `Cognitive Complexity` issue on
code climate

@EyMaddis EyMaddis closed this Jan 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment