Skip to content

/roadmap

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix padding issue with shortcuts in date picker #170

Closed
adriaanvanrossum opened this issue Nov 23, 2019 · 4 comments
Closed

Fix padding issue with shortcuts in date picker #170

adriaanvanrossum opened this issue Nov 23, 2019 · 4 comments
Labels
bug
Projects
Public roadmap

Comments

@adriaanvanrossum
Copy link
Contributor

@adriaanvanrossum adriaanvanrossum commented Nov 23, 2019 •
edited

Screenshot

cc @amritnagi
@adriaanvanrossum adriaanvanrossum added this to Features & bugs in Public roadmap via automation Nov 23, 2019
@adriaanvanrossum adriaanvanrossum moved this from Features & bugs to Planned in Public roadmap Nov 23, 2019
@adriaanvanrossum adriaanvanrossum moved this from Planned to In progress in Public roadmap Nov 23, 2019
@adriaanvanrossum

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

@adriaanvanrossum adriaanvanrossum commented Nov 25, 2019

Fixed, will deploy to production later today.
Public roadmap automation moved this from In progress to Implemented Nov 25, 2019
@james-k-fox

This comment has been minimized.

Sign in to view
Copy link

@james-k-fox james-k-fox commented Nov 25, 2019

I was going to suggest some CSS to fix pre-fixed date shortcuts but I see you have reported already resolving this. My suggestion was:
.shortcut-buttons-flatpickr-button { font-size: 12px; line-height: 20px; height: 20px; padding: 0 6px; margin: 7px 3px; }
@adriaanvanrossum

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

@adriaanvanrossum adriaanvanrossum commented Nov 26, 2019

Thanks @james-k-fox 🙏 It's more or less the same what we did 🥳

We also moved the shortcuts to the top of the date picker. It's all deployed now.

Screenshot
@james-k-fox

This comment has been minimized.

Sign in to view
Copy link

@james-k-fox james-k-fox commented Nov 26, 2019

Awesome! Thanks for the update :-)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
Public roadmap
  
Implemented
Milestone
No milestone
2 participants
@adriaanvanrossum @james-k-fox
You can’t perform that action at this time.