Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Browsers more/less button #196

Closed
Macro-Jackson opened this issue Jan 2, 2020 · 8 comments
Closed

Browsers more/less button #196

Macro-Jackson opened this issue Jan 2, 2020 · 8 comments
Assignees
Labels
bug

Comments

@Macro-Jackson
Copy link

@Macro-Jackson Macro-Jackson commented Jan 2, 2020

In the domain overview you see the selection of browsers. There you'll see a more button. But this does only change to less when clicked. Even though there are more browsers that viewed the site.

@adriaanvanrossum

This comment has been minimized.

Copy link
Contributor

@adriaanvanrossum adriaanvanrossum commented Jan 2, 2020

Does this also happen for you when you go to https://simpleanalytics.com/simpleanalytics.com?

@adriaanvanrossum adriaanvanrossum added the bug label Jan 2, 2020
@adriaanvanrossum adriaanvanrossum added this to Features & bugs in Public roadmap via automation Jan 2, 2020
@Macro-Jackson

This comment has been minimized.

Copy link
Author

@Macro-Jackson Macro-Jackson commented Jan 2, 2020

Nope. But see here for yourself. https://simpleanalytics.com/comphare.nl
Weird thing is that when you view only today then it works. At least no more/less button anymore.

@adriaanvanrossum

This comment has been minimized.

Copy link
Contributor

@adriaanvanrossum adriaanvanrossum commented Jan 2, 2020

So the issue covers two bugs:

  • It does not show all browsers that you see with the Stats API
  • The show more button should only show with more than 4 browsers

Thanks for reporting! Will fix.

@adriaanvanrossum adriaanvanrossum moved this from Features & bugs to Planned in Public roadmap Jan 2, 2020
@adriaanvanrossum

This comment has been minimized.

Copy link
Contributor

@adriaanvanrossum adriaanvanrossum commented Jan 3, 2020

@Macro-Jackson: @hellodeibu created a fix for this issue.

This resulted in a question for you. The numbers of the other browsers are so low that it's only shows 1 browser in the UI (we round them up to 1 percent). The Stats API shows more, but with very low numbers. If we would show those browsers the dashboard would look like this:

Screenshot

This would clutter the UI in my opinion but maybe you have a nice thought on this. What would you expect to see in the UI?

@Macro-Jackson

This comment has been minimized.

Copy link
Author

@Macro-Jackson Macro-Jackson commented Jan 3, 2020

I fully agree with that it would clutter the interface. But I want to have the option to see them. So I'd suggest following option:
Show up to 4? by default (limited by 1% percentage)
With "More..." button show up to 10? (limited by 1% percentage)
And additionally a "Show all..." button to show all <1%. That button will need some coding because it must be depending on if there is a "More..."button in the first place and if there are browsers <1%.

But this is more a general issue. Same for countries and pages and I guess referrals will also have this issue.

You can even make this a setting which is default off to keep it simple for the people who like simple and when "Show all value" button setting is set to ON that this feature will be displayed.

@adriaanvanrossum

This comment has been minimized.

Copy link
Contributor

@adriaanvanrossum adriaanvanrossum commented Jan 3, 2020

Thanks @Macro-Jackson, we will continue with developing it based on your comments.

@hellodeibu hellodeibu moved this from Planned to Implemented in Public roadmap Jan 10, 2020
@hellodeibu

This comment has been minimized.

Copy link

@hellodeibu hellodeibu commented Jan 10, 2020

Hello @Macro-Jackson! I'm happy to say that we've pushed an update that both fixes the bug you discovered and hopefully makes the agents list a bit more useful in situations like the one you experienced. Now when there are one or two very dominant browsers in your data, we decrease the level of rounding off somewhat to give you a more detailed view of the other browsers also being used. This way we keep the dashboard readable while at the same time offering more detail when needed.

What do you think? Does this make your experience better? Please let me know, I would love to hear your thoughts. And thank you so much for bringing this to our attention!

-Dave

@hellodeibu hellodeibu closed this Jan 17, 2020
@Macro-Jackson

This comment has been minimized.

Copy link
Author

@Macro-Jackson Macro-Jackson commented Jan 18, 2020

I think this is much better! Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Public roadmap
  
Implemented
3 participants
You can’t perform that action at this time.