Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encoding of URL going wrong. #229

Closed
Macro-Jackson opened this issue Jan 27, 2020 · 3 comments
Closed

Encoding of URL going wrong. #229

Macro-Jackson opened this issue Jan 27, 2020 · 3 comments
Labels
bug Something isn't working customer request Tasks created by customers via our website

Comments

@Macro-Jackson
Copy link

We have beautiful URL's. Yes there is some discussion about it if special characters should be allowed but IMHO they look way nicer and you are still being able to be found in Google.
For example: Västerås (a city in Sweden)
URL from Wikipedia: https://en.wikipedia.org/wiki/Västerås

Now an example of our URL: https://comphare.nl/Fjällräven-Re-Kånken-Slate-rugtas-tb6x.html

It does not present this way in the interface. It presents encoded like: /Fj%C3%A4llr%C3%A4ven-Re-K%C3%A5nken-Slate-rugtas-tb6x.html

Would be nice if it presents the real URL.

@adriaandotcom adriaandotcom added this to Features & bugs in Public roadmap via automation Jan 27, 2020
@adriaandotcom adriaandotcom added bug Something isn't working customer request Tasks created by customers via our website labels Jan 27, 2020
@adriaandotcom
Copy link
Contributor

adriaandotcom commented Jan 27, 2020

Thanks for your bug report, I agree it should look nice. Looks like we need decodeURIComponent somewhere:

decodeURIComponent('/Fj%C3%A4llr%C3%A4ven-Re-K%C3%A5nken-Slate-rugtas-tb6x.html')
// "/Fjällräven-Re-Kånken-Slate-rugtas-tb6x.html"

I wonder if we need the public script for this or if we need to do this in our main app. Will keep you posted on the progress.

It seems the browser does this:

location.pathname
// "/Fj%C3%A4llr%C3%A4ven-Re-K%C3%A5nken-Slate-rugtas-tb6x.html"

@adriaandotcom adriaandotcom moved this from Features & bugs to Planned in Public roadmap Jan 27, 2020
@adriaandotcom adriaandotcom moved this from Planned to Features & bugs in Public roadmap Oct 21, 2020
@jibsaramnim
Copy link

Hi @Macro-Jackson! I came across this older issue and I'm wondering now if I mistakenly forgot to mark this one as resolved, as I could swear I looked into this specific issue. Could you do me a favor and let me know if you still experience this issue?

Thanks so much!

@adriaandotcom
Copy link
Contributor

Public roadmap automation moved this from Features & bugs to Implemented Oct 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working customer request Tasks created by customers via our website
Projects
Public roadmap
  
Implemented
Development

No branches or pull requests

3 participants