Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable compression and caching #230

Open
Macro-Jackson opened this issue Jan 27, 2020 · 3 comments
Open

Enable compression and caching #230

Macro-Jackson opened this issue Jan 27, 2020 · 3 comments

Comments

@Macro-Jackson
Copy link

@Macro-Jackson Macro-Jackson commented Jan 27, 2020

Google Page Speed suggesting:
Opportunities: These suggestions can help your page load faster.
Enable text compression: 0.15 s
Text-based resources should be served with compression (gzip, deflate or brotli) to minimize total network bytes

URL: /app.js
Size 4 KB
Potential Savings 2KB

@LeCodeCo

This comment has been minimized.

Copy link

@LeCodeCo LeCodeCo commented Feb 3, 2020

Should be as simple as a change to the webserver config. This is easy to do with Nginx.

@adriaanvanrossum

This comment has been minimized.

Copy link
Contributor

@adriaanvanrossum adriaanvanrossum commented Feb 3, 2020

We use Server Side Includes (ssi) to include the hostname of the file. That's probably why it doesn't work right now. We will move this server to Amsterdam soon, so we will fix this then as well.

Test it with curl -H "Accept-Encoding: gzip" -I https://sa.nomadlist.com/app.js

@adriaanvanrossum adriaanvanrossum added this to Features & bugs in Public roadmap via automation Feb 3, 2020
@adriaanvanrossum adriaanvanrossum changed the title Enable compression Enable compression and caching Feb 13, 2020
@adriaanvanrossum

This comment has been minimized.

Copy link
Contributor

@adriaanvanrossum adriaanvanrossum commented Feb 13, 2020

Reported by @Jivings in #244:

I think a couple of things are mis-configured with the script caching.
The expire age is only set to 1 hour (seems quite low);

cache-control: max-age=3600

There's no last-modified or e-tag header (meaning the browser can't invalidate the cache efficiently).

image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Public roadmap
  
Features & bugs
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.