Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make today dotter line in chart optional or fix it #504

Open
adriaanvanrossum opened this issue Jan 5, 2021 · 9 comments
Open

Make today dotter line in chart optional or fix it #504

adriaanvanrossum opened this issue Jan 5, 2021 · 9 comments
Labels
customer request Tasks created by customers via our website

Comments

@adriaanvanrossum
Copy link
Contributor

adriaanvanrossum commented Jan 5, 2021

Some customers don't like the today part. We should make this optional and just hide the while today thing when disabled.

@RubenVanEldik via Twitter DM

@adriaanvanrossum adriaanvanrossum added the customer request Tasks created by customers via our website label Jan 5, 2021
@adriaanvanrossum adriaanvanrossum added this to Features & bugs in Public roadmap via automation Jan 5, 2021
@RubenVanEldik
Copy link

Thank you for taking it up!

My main issue with the dotted line right now is that it goes to 0 for all future hours. This looks a bit weird and makes reading the number of visitors in the current hour quite hard. The dotted line might be fine if it just stopped at the current hour, instead of going to 0.

This also makes more sense since you're using an area-graph, and there is now also some colored area below the current hour and hour+1, which is technically incorrect. 🙃

@adriaanvanrossum adriaanvanrossum added the bug Something isn't working label Jan 5, 2021
@adriaanvanrossum adriaanvanrossum changed the title Make today dotter line in chart optional Make today dotter line in chart optional or fix it Jan 5, 2021
@adriaanvanrossum
Copy link
Contributor Author

So it's showing you the next hour? That's a bug! Let's fix that.

@RubenVanEldik
Copy link

Well, this is only a problem in the day view. It shows all hours of the day, which is fine, but the line going back to 0 makes it seem a bit abrupt.

IMG_3F345696289A-1

@jibsaramnim jibsaramnim removed the bug Something isn't working label Jan 24, 2021
@adriaanvanrossum
Copy link
Contributor Author

What would expect in this daily view situation @RubenVanEldik?

@RubenVanEldik
Copy link

The problem is that the dotted line goes to 0 for all future hours. This makes it especially hard to read if the number of view for the current hour are roughly half of last hour, since it looks like the dotted line goes in a linear line to 0. (while in reality it goes from 600 last hour to 300 this hour to 0 next hour.

I can think of 3 solutions:

  1. Use a bar chart. The number of visitors per hour are often not very related from one hour to the next (except if you have a big spike due to HN/Twitter etc.). Since there isn't really a trend it makes a bit more sense to use a bar chart.

  2. Make the line from n-1 to n dotted and remove the line for n to >n.

103649063-215a0580-4f5e-11eb-8e83-4bf510adb901

  1. Make the dotted line move forward at the same rate of the current hour. This kind of shows what would happen if the site keeps the same pace as the current hour and makes it even easier to see the number of views for the current hour. (this is an interesting approach, though I think it might lead to confusion for some users).

103649063-215a0580-4f5e-11eb-8e83-4bf510adb901

@RubenVanEldik
Copy link

My preference is for option 1, since its technically the best way to show a non-trend dataset.

@adriaanvanrossum
Copy link
Contributor Author

Thanks! The bar chart will have "empty" hours as well, right?

@RubenVanEldik
Copy link

Yes, probably a striped/different colour/semi-transparant bar for the current hour and no bars for all future hours.

@amritnagi
Copy link

Not sure if it is possible but I think a nice thing to do would be to show a dot for the current hour value and have a pulse effect on it to show its “live” count (can mock something up later)

@jibsaramnim jibsaramnim removed their assignment Jan 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
customer request Tasks created by customers via our website
Projects
Public roadmap
  
Features & bugs
Development

No branches or pull requests

4 participants