Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix disableing mailto onclick events in automated events script #511

Open
adriaanvanrossum opened this issue Jan 9, 2021 · 0 comments
Open

Fix disableing mailto onclick events in automated events script #511

adriaanvanrossum opened this issue Jan 9, 2021 · 0 comments
Labels
bug Something isn't working customer request Tasks created by customers via our website
Projects
Public roadmap

Comments

@adriaanvanrossum
Copy link
Contributor

I just wanted to let you know that your JavaScript for events caused an interesting behavior when we didn't want to have tracking for mailto links. Even though it generated onclick="undefined return false" - maybe you want to update your code that you wrap the whole block into a "if (collect)" so it looks like the attachment.

Also thank you for the insights on your tech stack, really nice!

image

See HS

@adriaanvanrossum adriaanvanrossum added bug Something isn't working customer request Tasks created by customers via our website labels Jan 9, 2021
@adriaanvanrossum adriaanvanrossum added this to Features & bugs in Public roadmap via automation Jan 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working customer request Tasks created by customers via our website
Projects
Public roadmap
  
Features & bugs
Milestone
No milestone
Development

No branches or pull requests
1 participant
@adriaanvanrossum