Dynamic Path for LogoHeader + copy icon image #20

Merged
merged 2 commits into from Mar 8, 2012

Conversation

Projects
None yet
5 participants
@gogodanny
Contributor

gogodanny commented Feb 13, 2012

  1. The copy icon is broken (if you didn't with theme name "pear" or when it's not installed in first level).
    Therefore, i made the image path dynamically according to the theme path.
  2. Header logo and text link is not dynamic (will not work wordpress install in sub folder using custom domain name), therefore i use wp standard variable to replace it.

gogodanny added some commits Feb 13, 2012

Make "icon-copy.png", image path dynamically according to the theme.
The copy icon is broken (if you didn't with theme name "pear" or when it's not installed in first level).
Therefore, i made the image path dynamically according to the theme path.

in loop-single.php

/ /Line 36

<img src="<?php bloginfo('template_directory'); ?>/images/icon-copy.png" title="" alt="copy" />

// Line 43

<img src="<?php bloginfo('template_directory'); ?>/images/icon-copy.png" title="" alt="copy" />

Signed-off-by: Danny Chang <me@imdanny.com>
Dynamic path for header logo
The current link will not work if you have pears installed in a sub-folder in custom domain.

The fix is using standard wp veritable to define the path.

Signed-off-by: Danny Chang <me@imdanny.com>
@itreptil

This comment has been minimized.

Show comment Hide comment
@itreptil

itreptil Mar 8, 2012

@simplebits we really need this change. please merge this two commits

itreptil commented Mar 8, 2012

@simplebits we really need this change. please merge this two commits

simplebits added a commit that referenced this pull request Mar 8, 2012

Merge pull request #20 from gogodanny/master
Dynamic Path for LogoHeader + copy icon image

@simplebits simplebits merged commit bd6211c into simplebits:master Mar 8, 2012

@simplebits

This comment has been minimized.

Show comment Hide comment
@simplebits

simplebits Mar 8, 2012

Owner

Done!

Owner

simplebits commented Mar 8, 2012

Done!

@itreptil

This comment has been minimized.

Show comment Hide comment
@itreptil

itreptil Mar 8, 2012

thanks !

itreptil commented Mar 8, 2012

thanks !

@Mamaduka

This comment has been minimized.

Show comment Hide comment
@Mamaduka

Mamaduka Mar 9, 2012

I would suggest to use site_url() tag and other *_url()/*_uri() template tags instead of bloginfo equivalents. In this case you should use home_url(), because site url is where WordPress installed and some times it's different from home url.

I would suggest to use site_url() tag and other *_url()/*_uri() template tags instead of bloginfo equivalents. In this case you should use home_url(), because site url is where WordPress installed and some times it's different from home url.

@gudnm

This comment has been minimized.

Show comment Hide comment
@gudnm

gudnm Jul 5, 2012

I made a pull request (#28) to wrap up this issue. The footer logo was left out.

gudnm commented Jul 5, 2012

I made a pull request (#28) to wrap up this issue. The footer logo was left out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment