Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI for ruby-head to be run #705

Merged

Conversation

yui-knk
Copy link
Contributor

@yui-knk yui-knk commented Dec 8, 2018

We can not specify "trunk" for #platforms of Gemfile, so we can not run CI with "ruby-head".
This PR separates each gemfiles to 'gemfiles/*.gemfile'. We can specify arbitrary gem versions by this change.

We can not specify "trunk" for `#platforms` of Gemfile, so we
can not run CI with "ruby-head".
Test for "ruby-head" will be run by this commit.
@amatsuda
Copy link
Member

@yui-knk Nice work!

@amatsuda amatsuda merged commit b15b87e into simplecov-ruby:master Dec 12, 2018
@yui-knk
Copy link
Contributor Author

yui-knk commented Dec 12, 2018

Thanks!

@yui-knk yui-knk deleted the create_gemfiles_for_each_ruby_version branch December 12, 2018 03:29
PragTob added a commit that referenced this pull request Jun 25, 2019
Seems to have been broken during #705 but still worked on CI
cos it's in the different Gemfiles.

Hope this "fix" doesn't break anything else :)
PragTob added a commit that referenced this pull request Jun 25, 2019
Seems to have been broken during #705 but still worked on CI
cos it's in the different Gemfiles.

Hope this "fix" doesn't break anything else :)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants