Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Numerator and Denominator copy #2029

Merged
merged 7 commits into from Feb 3, 2021
Merged

Conversation

claudiovallejo
Copy link
Contributor

Story card: ch2491

Because

BP controlled, BP not controlled, and Missed visits rates appear in the "Home" and "Reports" sections of our Dashboard but use different copy. This PR creates a CopyHelper to create copy constants and reuse the same copy across our Dashboard.

This addresses

  • Creates CopyHelper
  • Creates constants for BP controlled, BP not controlled, and Missed visits numerators
  • Creates a constant for the denominator of the above rates
  • Uses CopyHelper to display numerator and denominator copy in the "Home" "BP controlled", "BP not controlled", and "Missed visits" sections
  • Uses CopyHelper to display numerator and denominator copy in the "Reports" "Overview" section

Screenshots

Reports: Overview cards
image

Reports: Visit of all hypertensive patients
image

Reports: Child tables
image

Home: BP controlled
image

Home: BP not controlled
image

Home: Missed visits
image

@shortcut-integration
Copy link

This pull request has been linked to Clubhouse Story #2491: Numerator and Denominator CopyHelper.

app/helpers/copy_helper.rb Outdated Show resolved Hide resolved
@harimohanraj89 harimohanraj89 temporarily deployed to simple-review-pr-2029 February 2, 2021 23:43 Inactive
@harimohanraj89 harimohanraj89 temporarily deployed to simple-review-pr-2029 February 2, 2021 23:57 Inactive
@claudiovallejo claudiovallejo changed the title Numerator and Denominator CopyHelper Numerator and Denominator copy Feb 3, 2021
Copy link
Contributor

@kpethtel kpethtel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work moving the copy into localization!

@claudiovallejo claudiovallejo merged commit 5a3cb75 into master Feb 3, 2021
@claudiovallejo claudiovallejo deleted the update-denominator-copy branch February 3, 2021 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants