Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Multi-value variables incorrectly handled #23

Closed
rogerm opened this Issue · 2 comments

3 participants

@rogerm

the library incorrectly handles multiple occurrences of a parameter.

For example: http://foo.bar.net/path?a=123&a=456

Request being a such a thin wrapper over dict is problematic here. At the very least is needs to be a dictionary of lists (a list of tuples is a bit harder to work with). Which would require a custom urlencode and a custom update() method.

@ideasculptor

I just posted a fix for this, along with other issues, in Issue #10

https://github.com/simplegeo/python-oauth2/issues#issue/10

@zookos

use multiple values under the same key from the body (closed by f6a9f80)
Thanks to rogerm, ideasculptor, jiivan, timgraham.

@heckj heckj referenced this issue from a commit in heckj/python-oauth2
@zookos zookos use multiple values under the same key from the body (fixes #23)
Thanks to rogerm, ideasculptor, jiivan, timgraham.
0000e17
@felixleong felixleong referenced this issue from a commit in felixleong/python-oauth2
@zbowling zbowling Merge branch 'master' of git://github.com/simplegeo/python-oauth2
* 'master' of git://github.com/simplegeo/python-oauth2: (66 commits)
  Prepared changelog for build 165
  get_normalized_parameters() is required to exclude any oauth_signature that was already there, and it is required to preserve duplicate keys, even with identical values ref #46, fixes pull/49, thanks @zyegfryed
  Prepared changelog for build 164
  make it actually inspect the request, and fix the test to require the right things of the request ref #46, ref pull/49, thanks @zyegfryed
  Prepared changelog for build 163
  add test of #46; fixes #46
  Prepared changelog for build 162
  import parse_qs from cgi if it can't be imported from urlparse, thus regaining compatibility with Python 2.5 fixes #47 thanks to @vtsao, @subsume, @worksology
  Prepared changelog for build 161
  Include all parameters from URL, even ones that begin with "oauth_", in signature base.
  Prepared changelog for build 160
  Prepared changelog for build 159
  add another unicode test case to the tests just to show to user saevarom on github
  Prepared changelog for build 158
  keep empty params parsed from the URL (fixes #22)
  Prepared changelog for build 155
  use multiple values under the same key from the body (fixes #23) Thanks to rogerm, ideasculptor, jiivan, timgraham.
  Prepared changelog for build 154
  Prepared changelog for build 153
  add work-around for bug unicode-handling in urlparse in Python < 2.7, including tests
  ...

Conflicts:
	oauth2/__init__.py
	setup.py
	tests/test_oauth.py
2871118
@piguin piguin referenced this issue from a commit in piguin/python-oauth2
@zookos zookos use multiple values under the same key from the body (fixes #23)
Thanks to rogerm, ideasculptor, jiivan, timgraham.
f6a9f80
@rogerhu rogerhu referenced this issue from a commit in rbm/python-oauth2
Robert MacCloy Fix bug with multi-valued params in GET requests 47619b0
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.