Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

get_normalized_parameters() appends non oauth parameters twice #46

Closed
movieclips opened this Issue · 1 comment

2 participants

@movieclips

get_normalized_parameters is appending duplicate non-oauth parameters to the returned value of this method causing the method signature check to fail.

So a call to this url http://example.com/v2/search/videos?oauth_nonce=79815175&oauth_timestamp=1295397962&oauth_consumer_key=mykey&oauth_signature_method=HMAC-SHA1&q=car&oauth_version=1.0&offset=10&oauth_signature=spWLI%2FGQjid7sQVd5%2FarahRxzJg%3D

will cause get_normalized_parameters() to return oauth_consumer_key=mykey&oauth_nonce=79815175&oauth_signature_method=HMAC-SHA1&oauth_timestamp=1295397962&oauth_version=1.0&offset=10&offset=10&q=car&q=car

notice the duplicate "offset" and "q" parameters.

@zookos

add test of #46; closed by d8fdecb

@felixleong felixleong referenced this issue from a commit in felixleong/python-oauth2
@zbowling zbowling Merge branch 'master' of git://github.com/simplegeo/python-oauth2
* 'master' of git://github.com/simplegeo/python-oauth2: (66 commits)
  Prepared changelog for build 165
  get_normalized_parameters() is required to exclude any oauth_signature that was already there, and it is required to preserve duplicate keys, even with identical values ref #46, fixes pull/49, thanks @zyegfryed
  Prepared changelog for build 164
  make it actually inspect the request, and fix the test to require the right things of the request ref #46, ref pull/49, thanks @zyegfryed
  Prepared changelog for build 163
  add test of #46; fixes #46
  Prepared changelog for build 162
  import parse_qs from cgi if it can't be imported from urlparse, thus regaining compatibility with Python 2.5 fixes #47 thanks to @vtsao, @subsume, @worksology
  Prepared changelog for build 161
  Include all parameters from URL, even ones that begin with "oauth_", in signature base.
  Prepared changelog for build 160
  Prepared changelog for build 159
  add another unicode test case to the tests just to show to user saevarom on github
  Prepared changelog for build 158
  keep empty params parsed from the URL (fixes #22)
  Prepared changelog for build 155
  use multiple values under the same key from the body (fixes #23) Thanks to rogerm, ideasculptor, jiivan, timgraham.
  Prepared changelog for build 154
  Prepared changelog for build 153
  add work-around for bug unicode-handling in urlparse in Python < 2.7, including tests
  ...

Conflicts:
	oauth2/__init__.py
	setup.py
	tests/test_oauth.py
2871118
@piguin piguin referenced this issue from a commit in piguin/python-oauth2
@zookos zookos add test of #46; fixes #46 d8fdecb
@piguin piguin referenced this issue from a commit in piguin/python-oauth2
@zookos zookos make it actually inspect the request, and fix the test to require the…
… right things of the request

ref #46, ref pull/49, thanks @zyegfryed
a84d2cf
@piguin piguin referenced this issue from a commit in piguin/python-oauth2
@zookos zookos get_normalized_parameters() is required to exclude any oauth_signatur…
…e that was already there, and it is required to preserve duplicate keys, even with identical values

ref #46, fixes pull/49, thanks @zyegfryed
1178db3
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.