Drop support for ambient context-less scoping #365

Open
dotnetjunkie opened this Issue Dec 29, 2016 · 3 comments

Projects

None yet

2 participants

@dotnetjunkie
Collaborator

With #226 we added to possibility to flow Scope instances through the object graph, instead of using Ambient Context styles that depended on AsyncLocal<T> or ThreadLocal<T>.

Issue #364 however proves that this feature isn't complete yet.

The advantages of context-less scoping are slim however:

  • The performance benefits are neglectable.
  • Every modern platform has support for the required ambient context (Simple Injector can always be used).

Major downside of context-less scoping is the increased complexity that this model brings for the user, which is something that can be easily understood from #364.

Since there is ATM no documentation about this feature, chances are small that users are actually using this feature.

Instead of investing into this feature (as #364 suggests), we should instead drop this feature completely.

@dotnetjunkie dotnetjunkie added this to the Backlog milestone Dec 29, 2016
@TheBigRic

This seems the best option!

@dotnetjunkie
Collaborator

In case we drop support in v4, we should probably mark it as deprecated in v3.3.

@dotnetjunkie
Collaborator

Aaannnd..... it's gone :)

@dotnetjunkie dotnetjunkie added a commit that referenced this issue Feb 21, 2017
@dotnetjunkie dotnetjunkie Simplified WebRequestLifestyle.
WebRequestLifestyle could be simplified since support for ambient
contexts was dropped. Related to #365.
ba35361
@dotnetjunkie dotnetjunkie modified the milestone: v4, Backlog Feb 21, 2017
@dotnetjunkie dotnetjunkie self-assigned this Feb 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment