Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Scope.ParentScope public #502

Closed
dotnetjunkie opened this Issue Jan 10, 2018 · 1 comment

Comments

Projects
None yet
1 participant
@dotnetjunkie
Copy link
Collaborator

dotnetjunkie commented Jan 10, 2018

ParentScope is currently an internal property of Scope, which enables AsyncScopedLifestyle and ThreadScopedLifestyle to do nesting, by iterating up the scope stack.

Making ParentScope public however, does considerably simplify creating a custom lifestyle that caches instances in the outer scope, for instance as described in #501.

@dotnetjunkie dotnetjunkie added this to the v4.1 milestone Jan 10, 2018

@dotnetjunkie dotnetjunkie modified the milestones: v4.1, Backlog Feb 28, 2018

@dotnetjunkie

This comment has been minimized.

Copy link
Collaborator Author

dotnetjunkie commented Apr 22, 2019

Won't be adding this feature. Even after making ParentScope public, there are many quirks to consider. Users are better of changing their design instead of depending on ParentScope to build a custom lifestyle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.