Prevent first-chance exceptions

[dotnetjunkie]

There are still a few places in the Simple Injector code bases that swallow exceptions and continue. Newer versions of Visual Studio, however, show first chance exceptions by default in the debugger, and this behavior is quite hard to disable.

Because of this, it can lead to confusing situations, where users think there is a problem they need to fix, while everything is actually working fine.

Whenever possible, these first chance exceptions should be prevented.

[dotnetjunkie]

There are four places in particular that swallor exceptions:

• GenericTypeBuilder.IsImplementationApplicableToEveryGenericType
• GenericTypeBuilder.BuildClosedGenericImplementationBasedOnMatchingServiceType
• Container.SelectImplementationTypeConstructorOrNull
• ContainerOptions.IsConstructableType

The first two, inside the GenericTypeBuilder, are places that can't be easily fixed. They work around corner case scenario's when dealing with generic type constraints.

The last two, however, are the cases that should be fixed.

Problem with both the SelectImplementationTypeConstructorOrNull and IsConstructableType methods, however, is that they wrap a call to IConstructorResolutionBehavior.GetConstructor, which by design either returns a valid constructor or throws an exception.

These fixes can, therefore, only be made by changing IConstructorResolutionBehavior and thus introducing a breaking change.

[dotnetjunkie]

feature-557 branch created.

[dotnetjunkie]

API Changes:

• ConstructorInfo GetConstructor(Type) method of IConstructorResolutionBehavior interface replaced with ConstructorInfo? TryGetConstructor(Type, out string?) method.
• void Verify(InjectionConsumerInfo) method of IDependencyInjectionBehavior interface replaced with bool VerifyDependency(InjectionConsumerInfo, out string?) method.
• New LegacyBehaviorExtensions class added with the following two extension method:
  • ConstructorInfo GetConstructor(this IConstructorResolutionBehavior, Type)
  • void Verify(this IDependencyInjectionBehavior, InjectionConsumerInfo)
    These methods mimic the old behavior, which prevents calling code to be changed. (recompile is still required)