Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split SimpleInjector.Integration.AspNetCore.Mvc.Core package into two separate packages #587

Open
dotnetjunkie opened this issue Jul 13, 2018 · 0 comments

Comments

@dotnetjunkie
Copy link
Collaborator

@dotnetjunkie dotnetjunkie commented Jul 13, 2018

The SimpleInjector.Integration.AspNetCore.Mvc.Core package now contains both integration features for working with both Controllers and View Components. When building a Web API, however, View Components are not required. Taking a dependency on SimpleInjector.Integration.AspNetCore.Mvc.Core, however, will cause a dependency on Microsoft.AspNetCore.Mvc.ViewFeatures (and all of its dependencies) as well.

Splitting the package into a SimpleInjector.Integration.AspNetCore.Mvc.Core and SimpleInjector.Integration.AspNetCore.Mvc.ViewFeatures would therefore be a good idea.

Unfortunately, this change is a breaking change.

Do note that, at this point, nobody seems to bother about this dependency at all, since nobody has contacted us about this unwanted dependency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.