Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extra information to obsolete messages #681

Open
dotnetjunkie opened this Issue Apr 5, 2019 · 0 comments

Comments

Projects
None yet
1 participant
@dotnetjunkie
Copy link
Collaborator

dotnetjunkie commented Apr 5, 2019

Every version of Simple Injector contains obsolete messages, but the messages don't always describe when the Obsolete attribute will be treated as error and when the feature will be removed completely from the library.

It is, therefore, useful to add the following information to obsolete messages:

Will be treated as an error from version {version}. Will be removed in version {version}

Perhaps even add a unit test that verifies whether future messages comply with this rule.

Also, messages should not use any of the following redundant information (inspired by a Fody plugin):

  • Do not call this method
  • This method will be removed
  • This method is obsolete
  • The replacement method is

@dotnetjunkie dotnetjunkie added this to the Backlog milestone Apr 5, 2019

@dotnetjunkie dotnetjunkie modified the milestones: Backlog, v4.6 Apr 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.