Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Prevent disposing cross-wired dependencies #683
The Simple Injector integration packages allows cross wiring of services provided by the ASP.NET Core configuration system. In doing so, however, it partly takes control and ensures disposal. The Core configuration system, unfortunately, disposes those components as well, causing a dependency to be disposed twice.
Due to the definition of the dispose pattern, this shouldn't be a problem. Classes must allow
Developers, however, don't always work according to this pattern, and this might cause performance issues as dispose is called twice.
Since Simple Injector can not tak ownership of those components, it should let Core dispose of these instances (as there is no way to instruct Core to not dispose of those instances anyway) and prevent disposing them.
This does mean, however, introducing a change to the Simple Injector core library as it does not allow disabling the disposal of