Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking change between 4.6.2 and 4.7.0 #746

Closed
fanc-mso opened this issue Sep 2, 2019 · 3 comments
Closed

Breaking change between 4.6.2 and 4.7.0 #746

fanc-mso opened this issue Sep 2, 2019 · 3 comments
Labels

Comments

@fanc-mso
Copy link

@fanc-mso fanc-mso commented Sep 2, 2019

After updating the different SimpleInjector libraries from 4.6.2 to 4.7.0, this code no longer works in Startup.cs of a ASP.NET MVC Application (.NET Framework 4.7.2):

container.RegisterMvcControllers(Assembly.GetExecutingAssembly());

It throws error

System.ArgumentNullException: 'assemblies
Parameter name: The supplied elements in the array can't be null.'

I've tested Assembly.GetExecutingAssembly() and it's obviously not null so not sure what's causing this.

If I revert back to SimpleInjector 4.6.2 it works again.

Many thanks for looking into this or for providing me with an alternate solution to register my MVC Controllers.

@fanc-mso fanc-mso added the question label Sep 2, 2019
@dotnetjunkie dotnetjunkie added bug task and removed question labels Sep 2, 2019
@dotnetjunkie

This comment has been minimized.

Copy link
Collaborator

@dotnetjunkie dotnetjunkie commented Sep 2, 2019

Thank you for reporting this. This is indeed a regression that unfortunately happened while adding C# 8 support.

@dotnetjunkie

This comment has been minimized.

Copy link
Collaborator

@dotnetjunkie dotnetjunkie commented Sep 2, 2019

I pushed patch release v4.7.1 to NuGet. It should be available for you to download within the next hour.

@fanc-mso

This comment has been minimized.

Copy link
Author

@fanc-mso fanc-mso commented Sep 2, 2019

Many thanks for the quick fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.