New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Let Container and Scope classes implement IAsyncDisposable #791
Milestone
Comments
feature-791 branch created. |
dotnetjunkie
added a commit
that referenced
this issue
Apr 30, 2020
…n package. Now any component implementing IAsyncDisposable will be disposed, not only those that also implement IDisposable. #791.
dotnetjunkie
added a commit
that referenced
this issue
May 4, 2020
…ill also call all IDisposable.Dispose methods and calling Scope.Dispose will be a no-op after calling Scope.DisposeAsync. Also changed the locking behavior of Scope. Disposing is now not thread safe any longer. This didn't make much sense, as no one in their right mind would dispose from multiple threads. #791.
dotnetjunkie
added a commit
that referenced
this issue
May 4, 2020
…nc, and ensured the stack trace is stored after calling DisposeAsync. #791.
dotnetjunkie
added a commit
that referenced
this issue
May 4, 2020
The
This means that the following following Simple Injector builds will not support
|
dotnetjunkie
added a commit
that referenced
this issue
May 21, 2020
dotnetjunkie
added a commit
that referenced
this issue
May 21, 2020
dotnetjunkie
added a commit
that referenced
this issue
May 27, 2020
dotnetjunkie
added a commit
that referenced
this issue
Jun 10, 2020
dotnetjunkie
added a commit
that referenced
this issue
Jun 10, 2020
…nterface names instead of the simplified name. #791
dotnetjunkie
added a commit
that referenced
this issue
Jun 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Feature #778 adds async disposable support for ASP.NET Core, but even outside the realm of ASP.NET Core, async disposable support is useful in two places:
Scope
Container
.Because of the extra required
Microsoft.Bcl.AsyncInterfaces
package, I feel adding support to the core library is unsuited for v4, but we might want to reconsider for v5.The text was updated successfully, but these errors were encountered: