Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix app #669

Merged
merged 1 commit into from Mar 12, 2019

Conversation

Projects
None yet
3 participants
@lobster2012-user
Copy link
Contributor

lobster2012-user commented Mar 12, 2019

@dotnetjunkie dotnetjunkie merged commit dd196fc into simpleinjector:master Mar 12, 2019

1 check failed

continuous-integration/appveyor/pr AppVeyor build failed
Details
@lobster2012-user

This comment has been minimized.

Copy link
Contributor Author

lobster2012-user commented Mar 12, 2019

Hello!
@dotnetjunkie
Unfortunately, I'm not sure that it helped. The problem, it seems to me, must be solved very simply.

@dotnetjunkie

This comment has been minimized.

Copy link
Collaborator

dotnetjunkie commented Mar 12, 2019

Yes, I think there's more to it than changing the VS version, but as we don't support 2015 any longer, it seemed safe to merge this PR.

@lobster2012-user

This comment has been minimized.

Copy link
Contributor Author

lobster2012-user commented Mar 12, 2019

The old version of msbuild is still used.
https://ci.appveyor.com/project/simpleinjector/simpleinjector/builds/23021893
(Microsoft (R) Build Engine version 14.0.25420.1)

Perhaps you need to do another push in the master. Not sure.

#574
I see @hanabi1224 also tried ...

@dotnetjunkie

This comment has been minimized.

Copy link
Collaborator

dotnetjunkie commented Mar 12, 2019

Yes, and @qujck tried to figure out what hanabi tried to achieve.

@lobster2012-user

This comment has been minimized.

Copy link
Contributor Author

lobster2012-user commented Mar 12, 2019

@dotnetjunkie
I would add echo some-thing to see if the last appveyour is being used.

@lobster2012-user

This comment has been minimized.

Copy link
Contributor Author

lobster2012-user commented Mar 12, 2019

app
What about this setting?

@dotnetjunkie

This comment has been minimized.

Copy link
Collaborator

dotnetjunkie commented Mar 12, 2019

@qujck, do you know more about this?

I'm inclined to completely remove the build process, as I don't really know how to manage it, and it has proven to need a considerable amount of maintenance.

@qujck

This comment has been minimized.

Copy link
Collaborator

qujck commented Mar 12, 2019

I agree, we don't release from this pipeline making it a useless overhead

@dotnetjunkie

This comment has been minimized.

Copy link
Collaborator

dotnetjunkie commented Mar 12, 2019

@qujck, I removed the webhook from the repository's settings, but the pull requests tab still shows build failures. Do you know how to remove that?

@qujck

This comment has been minimized.

Copy link
Collaborator

qujck commented Mar 12, 2019

That build is still connected to appveyor - would hope another build of the same branch would no longer show a status.

@lobster2012-user

This comment has been minimized.

Copy link
Contributor Author

lobster2012-user commented Mar 13, 2019

I think that

1. Not used appveyor.yml
or not used correctly.
appveyor.bat is simply not correct.

2. I played with a build working image,
watching the ms build version change.

3.
2 tests failed, the first can be fixed. The second one needs to be ignored when building with appveyor, you have to correct appveyor

4. Without a normal CI, it will be difficult with PR ...

5. The fastest merging in my life, thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.