Skip to content
Browse files

Update create.php to work with recent changes

  • Loading branch information...
1 parent 11eeac2 commit 8d3eae70b214a4748c92b941765fd0bf54a39b6b @rmccue rmccue committed Feb 18, 2010
Showing with 2 additions and 2 deletions.
  1. +2 −2 create.php
View
4 create.php
@@ -1,6 +1,6 @@
<?php
-require_once 'simplepie.inc';
+require_once 'simplepie.class.php';
@hakre
hakre added a note Jun 2, 2012

This file does not exists. Can you shed more light into this why that change was made? Is that early 1.3 code that went into 1.2 by error?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
function normalize_character_set($charset)
{
@@ -141,7 +141,7 @@ function build_function()
if ($charsets = build_character_set_list())
{
$return = <<<EOF
-function charset(\$charset)
+public static function encoding(\$charset)
@hakre
hakre added a note Jun 2, 2012

This is not PHP 4 compatible code.

@rmccue
SimplePie member
rmccue added a note Jun 2, 2012

Oh, I see what you mean. This isn't really an issue though, since this tool won't be used again on 1.2.x unless absolutely necessary, and then it can be manipulated by hand.

@hakre
hakre added a note Jun 2, 2012

So it's okay to introduce PHP 5.x for the tools and the test-suite even the code of the library stays PHP 4 compatbile? I'm asking because I'd like to streamline the codebase a bit so it will become easier to switch from PHP 4 codebases to PHP 5 codebases and finally then to the new SimplePie which is not stable yet.

@rmccue
SimplePie member
rmccue added a note Jun 3, 2012

Tools, yes, test suite, no. The test suite has to be run on PHP 4 to work properly. The charset tool spits out a string, so that's agnostic of the PHP version.

In terms of streamlining the codebase, what did you have in mind? 1.2.x has to be API-compatible with 1.2.0, so it's mainly for bug fixes and such.

The master branch is fairly stable, it just needs more tests, especially for regressions. I need to be reasonably sure that there's no major API incompatibilities between 1.2 and 1.3.

@hakre
hakre added a note Jun 3, 2012

I was looking for a transition version of the 1.2 branch to target PHP 5 compatibility (the only issue I have so far with SimplePie 1.2.x). I have run an own PHP 5 port as well as I know about some other peoples ports and changes and I'd like to bring those together.

As you wrote the 1.2.x branch needs to stay on PHP 4, so I'm creating a new branch that actually is 1.2.x but for PHP 5.

I've seen that the testsuite does not run clean on PHP 5, so thanks for the hint that this is related to the PHP version. Good point to check when porting to PHP 5.

In doing the port I'm also re-writing the tests to PHPUnit, I guess that is interesting as well for your master branch as PHPUnit tests are easier to port.

You write it has to be API compatible with 1.2.0 which makes sense. Where do I find that API specification and how to validate compatibility? Or aren't you taking it that strict that you validate this automatically?

BTW would you create a branch of 1.2.x for PHP 5? I exemplary named mine one-dot-two-PHP5 but it's not ready to pull yet, I think I need to fix it's history, that was my first run. I might even do two, one main one that focus on PHP 5 only but "is" the 1.2 and one that also has additional contributions from the community (the stuff you find in the diverse forks, streamlined). Feedback and ideas warm-heartedly appreciated.

@rmccue
SimplePie member
rmccue added a note Jun 3, 2012

In doing the port I'm also re-writing the tests to PHPUnit, I guess that is interesting as well for your master branch as PHPUnit tests are easier to port.

master already uses PHPUnit, but with a framework to avoid having to rewrite all the old tests. If you want to change that, that's cool, but it's a whole bunch of work for no real gain.

You write it has to be API compatible with 1.2.0 which makes sense. Where do I find that API specification and how to validate compatibility? Or aren't you taking it that strict that you validate this automatically?

Essentially, I'll read over the changes and make sure that there's no intentional changes to it (addition/removal of methods, different method prototypes, etc) and then run the test suite. I'd also try out a bunch of example code from the wiki.

would you create a branch of 1.2.x for PHP 5?

I'm not really sure what the point of that would be. 1.3-dev is almost completely API-compatible, and certainly has a lot of bug fixes and improvements. Once it's compiled into a single tool (using one of the build tools), it's essentially the same structure as 1.2. I don't really have time to support both here, so you'll have to sell me on the benefits of that.

@hakre
hakre added a note Jun 3, 2012

I'm not really sure what the point of that would be.

Nothing special, just a PHP 5 port of 1.2. Has nothing to do with the code in 1.3. It's just that 1.2 is out, PHP 4 is over, many want to use 1.2 on PHP 5 based installs and have not the support for it they want to have. That branch would cover that. That's all, you won't even need to care much more than creating a new branch called one-dot-two-PHP5 for example, because others would do the work.

See it as an honor for your past work and the faith we have in your work in 1.3 to which I'm sure many want to update to when it's released.

Everything else is pretty cool, just would love to see your support here.

Edit: I created Issue #200

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
{
// Normalization from UTS #22
switch (strtolower(preg_replace('/(?:[^a-zA-Z0-9]+|([^0-9])0+)/', '\\1', \$charset)))

0 comments on commit 8d3eae7

Please sign in to comment.
Something went wrong with that request. Please try again.