Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Bug found in simplepie.inc function set_query #108

Closed
klabianco opened this Issue · 5 comments

2 participants

@klabianco

line 12162 Missing '=' character for replacing invalid characters.

this problem occurs when a url contains url.com/?foo=bar

@klabianco

this is version 1.2.1-dev also...

@klabianco

also, missing '&' character.

@rmccue
Owner

This looks like the same URL encoding bug. Can you confirm this is fixed in the latest version from the one-dot-two branch?

@klabianco

It is not fixed in the latest version

@rmccue
Owner

Confirmed that this error exists, and fixed in master in 4e022de

Not sure if I'm going to backport this to 1.2.1-dev yet. Will see how much effort it takes.

@rmccue rmccue closed this issue from a commit
@rmccue rmccue Update IRI percent-normalisation code.
Fixes a few tests, see https://gist.github.com/1187856 for before/after

Backport of 4e022de for one-dot-two. Fixes #108, fixes #112, maybe fixes #58.
76b5fd6
@rmccue rmccue closed this in 76b5fd6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.