Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
SimplePie_IRI::set_query() improperly decodes URLs passed in query string values #112
Ran into an issue in 1.2.1-dev where a URL that contains a query string value that contains another URL was improperly decoded. Example of the problem:
The patch below provides a fix by running SimplePie_IRI::replace_invalid_with_pct_encoding() on each argument in the query string rather than the whole thing.
It does still occur. I tested latest from
The suggested patch will work for this example, but will break (never ending loop) if URLs have brackets in, e.g. if you change
I'm not so familiar with IRI code, so nothing to suggest yet.